Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added sig-architecture to the webpage #1125

Merged
merged 2 commits into from
Jan 6, 2025
Merged

feat: added sig-architecture to the webpage #1125

merged 2 commits into from
Jan 6, 2025

Conversation

matbmoser
Copy link
Contributor

Description

Added the new sig-architecture repository to the webpage.

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

lgblaumeiser
lgblaumeiser previously approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@lgblaumeiser lgblaumeiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small corrections to improve readability and get rid of redundancy, no need to check it again

community/sigs/05_sig_architecture.md Outdated Show resolved Hide resolved
@matbmoser matbmoser requested a review from lgblaumeiser January 6, 2025 15:44
@matbmoser
Copy link
Contributor Author

@lgblaumeiser I have added your changes. Please approve again.

lgblaumeiser
lgblaumeiser approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@lgblaumeiser lgblaumeiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lgblaumeiser lgblaumeiser merged commit 3c416db into main Jan 6, 2025
5 checks passed
@lgblaumeiser lgblaumeiser deleted the docs/sig-architecture branch January 6, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lgblaumeiser lgblaumeiser lgblaumeiser approved these changes

@stephanbcbauer stephanbcbauer Awaiting requested review from stephanbcbauer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matbmoser @lgblaumeiser