fix: replace [kK]ey[cC]loac?k with [kK]eycloak #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drcgjung
approved these changes
Dec 6, 2023
Good catch! I will do that 😉 |
Can you manage this before merging? ;) |
|
I will fix the typos after my vacation ;-) Just let's keep this PR open until I fixed them as well. |
florianrusch-zf
dismissed stale reviews from FaGru3n and tomaszbarwicki
via
a71153e
florianrusch-zf
force-pushed
the
fix/518-fix-keycloak-spelling
branch
from
44f8e85 to
a71153e
Compare
florianrusch-zf
changed the title
florianrusch-zf
changed the title
|
I have left the following as it is because these occurrences refer to a script in another repo which I don't want to touch at the moment:
|
|
Wanted to merge PR, but it has merge conflicts. Please resolve merge conflicts @florianrusch-zf |
|
@florianrusch, @carslen I could take over this PR, if needed |
|
i have already merged the changes locally and will push them later 😉
…________________________________
From: Stephan Bauer ***@***.***>
Sent: Wednesday, January 24, 2024 4:49:33 PM
To: eclipse-tractusx/eclipse-tractusx.github.io ***@***.***>
Cc: Florian Rusch ***@***.***>; Mention ***@***.***>
Subject: Re: [eclipse-tractusx/eclipse-tractusx.github.io] fix: replace [kK]ey[cC]loac?k with [kK]eycloak (PR #519)
Achtung: Diese E-Mail stammt von einem externen Absender. Bitte vermeide es, Anhänge oder externe Links zu öffnen
@florianrusch<https://github.com/florianrusch>, @carslen<https://github.com/carslen> I could take over this PR, if needed
—
Reply to this email directly, view it on GitHub<#519 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AXGJYNX4USO32EOXYIWIWETYQEUQ3AVCNFSM6AAAAABACKFWR6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBYGQYDKMZXGA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
florianrusch-zf
force-pushed
the
fix/518-fix-keycloak-spelling
branch
from
a71153e to
7b7db15
Compare
stephanbcbauer
approved these changes
Jan 25, 2024
florianrusch-zf
requested review from
FaGru3n
and removed request for
manojava-gk
carslen
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are 92 occurrences of the term "KeyCloak" in the repository. However, the correct spelling is "Keycloak" (source: https://www.keycloak.org/).
Fixes #518
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: