Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add trg 2-4 leading readme example #551

Merged
merged 8 commits into from
Jan 10, 2024
Merged

docs: add trg 2-4 leading readme example #551

merged 8 commits into from
Jan 10, 2024

Conversation

FaGru3n
Copy link
Contributor

@FaGru3n FaGru3n commented Dec 12, 2023

Description

  • add example for leading repo readme
  • add link to Readme TRG 1-01

fixes eclipse-tractusx/sig-infra#370

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

almadigabor
almadigabor previously approved these changes Dec 12, 2023
Copy link
Contributor

@almadigabor almadigabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FaGru3n FaGru3n requested a review from almadigabor December 13, 2023 10:16
Copy link
Contributor

@hzierer hzierer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/release/trg-2/trg-2-4.md Outdated Show resolved Hide resolved
docs/release/trg-2/trg-2-4.md Outdated Show resolved Hide resolved
docs/release/trg-2/trg-2-4.md Outdated Show resolved Hide resolved
stephanbcbauer
stephanbcbauer previously approved these changes Dec 14, 2023
Copy link
Member

@stephanbcbauer stephanbcbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the changes themselves are good and appropriate, but ... will contact you because of the TRG itself :)

docs/release/trg-2/trg-2-4.md Outdated Show resolved Hide resolved
docs/release/trg-2/trg-2-4.md Outdated Show resolved Hide resolved
docs/release/trg-2/trg-2-4.md Outdated Show resolved Hide resolved
docs/release/trg-2/trg-2-4.md Outdated Show resolved Hide resolved
@FaGru3n FaGru3n requested a review from hzierer December 19, 2023 07:30
Copy link
Contributor

@hzierer hzierer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added one suggestion, the rest LGTM.

docs/release/trg-2/trg-2-4.md Outdated Show resolved Hide resolved
Copy link
Contributor

@almadigabor almadigabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FaGru3n FaGru3n merged commit 9949fa2 into main Jan 10, 2024
4 checks passed
@FaGru3n FaGru3n deleted the docs/update-trg2-4 branch January 10, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TRG 2.04: Align with 1.01
5 participants