Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: version update #554

Conversation

manojava-gk
Copy link
Contributor

@manojava-gk manojava-gk commented Dec 13, 2023

change the version of dcm from 3.1.0 to 0.1.0 in changelog page

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

Copy link
Contributor

@FaGru3n FaGru3n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SebastianBezold
Copy link
Contributor

Hi @manojava-gk,

AFAIK, the CHANGELOG is pulled in via remote-content-plugin. At least it is configured there.
Is this a manual change, or is this done via build? Is this a change, that is also done in the the "true" CHANGELOG in eclipse-tractusx/tractus-x-release.

Would be nice, if you can provide this as information when creating the PR

@maximilianong
Copy link
Contributor

Hi @manojava-gk,

AFAIK, the CHANGELOG is pulled in via remote-content-plugin. At least it is configured there. Is this a manual change, or is this done via build? Is this a change, that is also done in the the "true" CHANGELOG in eclipse-tractusx/tractus-x-release.

Would be nice, if you can provide this as information when creating the PR

Hi @SebastianBezold its a manual change - I don't know where this information came from. Here is the truth on KIT level with 0.1.0 (https://eclipse-tractusx.github.io/docs-kits/kits/DCM%20Kit/changelog).

@manojava-gk can you please change it in the true changelog aswell (https://github.com/eclipse-tractusx/tractus-x-release/blob/main/CHANGELOG.md).

@SebastianBezold
Copy link
Contributor

Hi @maximilianong,

I won't change this without any notice. The CHANGELOG.md was prepared by release management (@RolaH1t) together with @Siegfriedk. If there has been miscommunication, please clarify it together.

This whole issue raises the question, why we keep two versions of the CHANGELOG and even have different info in it.
I would highly appreciate, if we can get rid of the CHANGELOG.md file in this repository and only link to the original source. This will prevent us from publishing wrong information

@maximilianong
Copy link
Contributor

Hi @SebastianBezold - we did this as a quick fix, because in general it's already too late. I think we (Mano & me) should not take over the responsibility of information in a different repository. I think we can close this PR here then and wait for the official fix.

@SebastianBezold
Copy link
Contributor

@maximilianong, but you have to address it, if it was a mistake. I think i'm going to remove the CHANGELOG.md in this repo here and provide a link to a the original source on a better suited page.
Will keep you posted in this PR here, once I've prepared a suggestion.

For now, I think keeping the files in sync is better than to have them containing different info

@Siegfriedk
Copy link
Contributor

@maximilianong the whole path is wrong btw. : https://eclipse-tractusx.github.io/docs-kits/kits/DCM%20Kit/changelog looks right while yours references 3.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants