-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: version update #554
bugfix: version update #554
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi @manojava-gk, AFAIK, the CHANGELOG is pulled in via remote-content-plugin. At least it is configured there. Would be nice, if you can provide this as information when creating the PR |
Hi @SebastianBezold its a manual change - I don't know where this information came from. Here is the truth on KIT level with 0.1.0 (https://eclipse-tractusx.github.io/docs-kits/kits/DCM%20Kit/changelog). @manojava-gk can you please change it in the true changelog aswell (https://github.com/eclipse-tractusx/tractus-x-release/blob/main/CHANGELOG.md). |
Hi @maximilianong, I won't change this without any notice. The This whole issue raises the question, why we keep two versions of the |
Hi @SebastianBezold - we did this as a quick fix, because in general it's already too late. I think we (Mano & me) should not take over the responsibility of information in a different repository. I think we can close this PR here then and wait for the official fix. |
@maximilianong, but you have to address it, if it was a mistake. I think i'm going to remove the For now, I think keeping the files in sync is better than to have them containing different info |
@maximilianong the whole path is wrong btw. : https://eclipse-tractusx.github.io/docs-kits/kits/DCM%20Kit/changelog looks right while yours references 3.1.0 |
change the version of dcm from 3.1.0 to 0.1.0 in changelog page
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: