Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: change community gallery faq target #555

Closed

Conversation

manojava-gk
Copy link
Contributor

@manojava-gk manojava-gk commented Dec 13, 2023

change faq link in community gallery to Developer FAQ

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

FaGru3n

This comment was marked as outdated.

Copy link
Contributor

@SebastianBezold SebastianBezold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you are already on it, please change the title.
We do have 3 or more FAQ pages on our website. So what does this link actually forward to?

Also for future PRs, please provide more descriptive titles

@maximilianong
Copy link
Contributor

When you are already on it, please change the title. We do have 3 or more FAQ pages on our website. So what does this link actually forward to?

Also for future PRs, please provide more descriptive titles

I created an issue for that: #556
Will discuss this with @danielmiehle

For now I think this one is a quick fix.

@maximilianong
Copy link
Contributor

@SebastianBezold your change request is blocking this at the moment. Can we agree on the issue I created. We will take this topic but not today.

@SebastianBezold
Copy link
Contributor

@maximilianong,

changing the title is a matter of seconds, so i think we should amend that.
My suggestion would be "Developer FAQ".

Just switching from left to right without a proper title is not worth merging in my opinion

@manojava-gk manojava-gk changed the title bugfix: change link bugfix: change community gallery faq target Dec 13, 2023
@FaGru3n FaGru3n dismissed their stale review December 13, 2023 10:39

hint to contributing guideline

@carslen carslen added the stale Items without activities label Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Items without activities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants