-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: copyright clarification for modular production KIT #557
fix: copyright clarification for modular production KIT #557
Conversation
hi @dominikoeh thanks for your contribution, did also checked the Dependencies and licence information? because it is not check marked? and also a little info you can request reviewers by adding them in the reviewer section 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please no changes on the 23.12 - this one is released. You can change the file in the "next".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Talked to @danielmiehle - change is approved.
No content change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, looke quite ok but some symbols seems a bit confusing why to change that in that way
FYI @AngelikaWittek,
could you maybe give us a hint which is the proper format in this way? like our TRG https://eclipse-tractusx.github.io/docs/release/trg-7/trg-7-07#documentation
IMHO i think this should be the format we are searching for
SPDX-FileCopyrightText: 2023 ThirdCompany
docs-kits_versioned_docs/version-23.12/kits/Modular Production Kit/page_adoption-view.md
Outdated
Show resolved
Hide resolved
docs-kits_versioned_docs/version-23.12/kits/Modular Production Kit/page_adoption-view.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Fabian Grün <[email protected]>
8154a5b
… Kit/page_adoption-view.md Co-authored-by: Fabian Grün <[email protected]>
… Kit/page_adoption-view.md Co-authored-by: Fabian Grün <[email protected]>
Co-authored-by: Fabian Grün <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Clarification of copyright notice in the Modular Production KIT. The current release states
where it should have been
@wehrstedt-jan
@danielmiehle @maximilianong
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: