Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: copyright clarification for modular production KIT #557

Merged
merged 6 commits into from
Feb 13, 2024

Conversation

dominikoeh
Copy link
Contributor

@dominikoeh dominikoeh commented Dec 13, 2023

Description

Clarification of copyright notice in the Modular Production KIT. The current release states

Fraunhofer Institute of Optronics, System Technology and Image Exploitation (IOSB)

where it should have been

Fraunhofer-Gesellschaft zur Foerderung der angewandten Forschung e.V. (represented by Fraunhofer IWU & Fraunhofer IOSB & Fraunhofer IPA)

@wehrstedt-jan

@danielmiehle @maximilianong

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@FaGru3n
Copy link
Contributor

FaGru3n commented Dec 18, 2023

hi @dominikoeh thanks for your contribution, did also checked the Dependencies and licence information?

because it is not check marked? and also a little info you can request reviewers by adding them in the reviewer section 😉

image

danielmiehle
danielmiehle previously approved these changes Dec 18, 2023
Copy link
Contributor

@maximilianong maximilianong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please no changes on the 23.12 - this one is released. You can change the file in the "next".

maximilianong
maximilianong previously approved these changes Dec 18, 2023
Copy link
Contributor

@maximilianong maximilianong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talked to @danielmiehle - change is approved.
No content change.

Copy link
Contributor

@FaGru3n FaGru3n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, looke quite ok but some symbols seems a bit confusing why to change that in that way

FYI @AngelikaWittek,

could you maybe give us a hint which is the proper format in this way? like our TRG https://eclipse-tractusx.github.io/docs/release/trg-7/trg-7-07#documentation

IMHO i think this should be the format we are searching for

SPDX-FileCopyrightText: 2023 ThirdCompany

@dominikoeh dominikoeh dismissed stale reviews from maximilianong and danielmiehle via 8154a5b January 31, 2024 13:37
@dominikoeh dominikoeh requested a review from FaGru3n February 1, 2024 08:08
Copy link
Contributor

@FaGru3n FaGru3n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maximilianong maximilianong merged commit 32aeb8a into eclipse-tractusx:main Feb 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants