Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(ecopass-kit): Updated the EcoPass KIT Operation View #789

Conversation

matbmoser
Copy link
Contributor

@matbmoser matbmoser commented Mar 25, 2024

Why do we create this PR?

We want to update the operation view from the Eco Pass kit for release 24.05.

What we want to achieve with this PR?

Have a operation view that is referencing to external kits configuration. Indicating just the examples for the Digital Product Pass use case.

What's new?

Added

  • Added references to the other kits in the Tractus-X webpage
  • Added notices indicating policies, edc asset configuration and dtr configurations are dependant in the other kits

Updated

  • Updated edc configuration payloads to ones used in 'v0.6.0'

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

  • DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs. (NO DEPENDENCIES)
  • Copyright and license header are present on all affected files
  • LINTING issues are resolved.
  • CHANGELOG is updated

@matbmoser matbmoser added documentation Improvements or additions to documentation enhancement New feature or request labels Mar 25, 2024
@matbmoser matbmoser requested a review from LuisRickert March 25, 2024 17:07
@matbmoser matbmoser self-assigned this Mar 25, 2024
@matbmoser matbmoser changed the title docs(kit): Updated EcoPass KIT operation view docs(ecopass-kit): Updated EcoPass KIT operation view Mar 25, 2024
@matbmoser matbmoser marked this pull request as draft March 25, 2024 17:10
@matbmoser matbmoser changed the title docs(ecopass-kit): Updated EcoPass KIT operation view docs(ecopass-kit): Updated the EcoPass KIT Operation View Mar 25, 2024
@LuisRickert
Copy link
Contributor

  • fixed md linting
  • updated changelog

@matbmoser matbmoser marked this pull request as ready for review April 9, 2024 15:17
@matbmoser
Copy link
Contributor Author

Linting is also working here :)

danielmiehle
danielmiehle previously approved these changes May 15, 2024
Copy link
Contributor

@danielmiehle danielmiehle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@HFocken HFocken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor detail to be fixed, then good to go!


- Updated battery pass model to latest version `v4.0.0`
- Updated Business Architecture Diagram

## [0.1.0] - 2023-08-11

### Added
### 23.08 Added
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change to 23.09 - 23.08 does not exist

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done


- move KIT to Tractus-X repository
- Updated Software Architecture guide with descriptive documentation

### Issues Fixed
### 23.08 Issues Fixed
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link

@HFocken HFocken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the change requests!

Copy link
Member

@jSchuetz88 jSchuetz88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update of the KIT, only one minor remark from my side.

| Submodel Server | The data source adhering to a subset of the Submodel API as defined in AAS Part-2 3.0. Where the Passport Aspects are stored | [FA³ST-Framework](https://github.com/FraunhoferIOSB/FAAAST-Service), [Eclipse Basyx](https://github.com/eclipse-basyx/basyx-java-sdk), [AASX Server](https://github.com/admin-shell-io/aasx-server) | CX - 0002 |
| EDC | Main gateaway to the network. In this use case two EDC need be existing, one connected to the Digital Product Pass (EcoPass KIT) [EDC Consumer] and another to the Provider Catena-X components [EDC Provider] | [eclipse-tractusx/tractusx-edc](https://github.com/eclipse-tractusx/tractusx-edc) | CX - 0018 |
| EDC | Main gateaway to the network. In this use case two EDC need be existing, one connected to the Digital Product Pass (EcoPass KIT) [EDC Consumer] and another to the Provider Catena-X components [EDC Provider] | [eclipse-tractusx/tractusx-edc](https://github.com/eclipse-tractusx/tractusx-edc) | CX - 0018 OR [Connector KIT](https://eclipse-tractusx.github.io/docs-kits/category/connector-kit) |
| Digital Product Pass | The [**EcoPass KIT**] reference implementation. The application is responsible for retrieving the passports and interacting with the services listed above. | [eclipse-tractusx/digital-product-pass](https://github.com/eclipse-tractusx/digital-product-pass) | CX - 0096 |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CX-Identifier (CX-0096) should be updated to "CX-0143" (Use Case Circular Economy - Digital Product Passport Standard 1.0.0) as the successor of CX-0096 in R24.05.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, not sure thought if it will still be maintained because of IP issues...

danielmiehle
danielmiehle previously approved these changes May 24, 2024
Copy link
Contributor

@danielmiehle danielmiehle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

maximilianong
maximilianong previously approved these changes May 24, 2024
@danielmiehle
Copy link
Contributor

@matbmoser There are some new conflicting files. Would you be so kind to fix it?

@matbmoser matbmoser dismissed stale reviews from maximilianong and danielmiehle via a175287 May 24, 2024 12:41
@matbmoser
Copy link
Contributor Author

Done @danielmiehle !

@matbmoser
Copy link
Contributor Author

Lets merge this PR first before #790

@maximilianong maximilianong merged commit 98d0379 into eclipse-tractusx:main May 27, 2024
5 checks passed
@LuisRickert LuisRickert deleted the ECO-Pass-KIT-Update-24.05-Operations-View branch June 10, 2024 16:39
@matbmoser matbmoser linked an issue Jul 5, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Release KIT 24.05
7 participants