docs(ecopass-kit): Updated the EcoPass KIT Software Development View #791

matbmoser · 2024-03-25T17:19:29Z

Why do we create this PR?

We want to update the software development view from the Eco Pass kit for release 24.05.

What we want to achieve with this PR?

Have the software development view referencing the other KITs from Tractus-X in the list of standards.
Updated latest functionalities added to the KIT reference implementation.

What's new?

Added

Added reference to other Tractus-X KITs in the list of standards and prerequisites in the Software Development View
Added single api retrival flow and api documentation from the DPP reference implementation
Added reference to the digital product pass verification feature coming in 24.05
Added description of digital product pass addons

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs. (NO DEPENDENCIES)
Copyright and license header are present on all affected files
LINTING issues are resolved.
CHANGELOG updated

…oftware-View

matbmoser · 2024-04-25T12:01:55Z

Ok I checked for the linting and now it it is working.

…oftware-View

arnoweiss · 2024-05-07T15:48:42Z

docs-kits/kits/Eco_Pass_KIT/page-software-development-view.md

+      {
+        "key" : "assetLifecyclePhase",
+        "value": "AsBuilt"
+      },


This is not mandated by the industry core for R24-05 anymore. Leave it in only if you want to go beyond the compatibility guarantees of CX.

@matbmoser should we leave this is ?

You can remove it, we need just the digital twin type, that's mandatory

HFocken

Thank you - minor detail change required, then good to go!

HFocken · 2024-05-15T14:17:12Z

docs-kits/kits/Eco_Pass_KIT/changelog.md


 - Updated battery pass model to latest version `v4.0.0`
 - Updated Business Architecture Diagram

 ## [0.1.0] - 2023-08-11

-### Added
+### 23.08 Added


Please change to 23.09 (also below) - 23.08 does not exist.

danielmiehle

LGTM

matbmoser · 2024-05-17T06:22:19Z

Before we merge this I need to include a link to your digital product pass tutorial and verification addons

HFocken

Thank you for addressing the change requests!

arnoweiss · 2024-05-23T09:43:41Z

Y'all are still failing the dash-licence and markdown-lint actions. Also, when building the website, there's a lot of warnings wrt to figures in the eco-pass-kit [1]. Is this addressed in this PR?

[1]

jSchuetz88

Thank you for the update of the KIT, looks good to me. Only one minor remark.

jSchuetz88 · 2024-05-24T01:47:01Z

docs-kits/kits/Eco_Pass_KIT/page-software-development-view.md

 | Submodel Server       | The data source adhering to a subset of the Submodel API as defined in AAS Part-2 3.0. Where the Passport Aspects are stored                                                                                            | [FA³ST-Framework](https://github.com/FraunhoferIOSB/FAAAST-Service), [Eclipse Basyx](https://github.com/eclipse-basyx/basyx-java-sdk), [AASX Server](https://github.com/admin-shell-io/aasx-server)                                                                                                          | CX - 0002                                                   |
-| EDC                   | Main gateaway to the network. In this use case two EDC need be existing, one connected to the Digital Product Pass (EcoPass KIT) [EDC Consumer] and another to the Provider Catena-X components [EDC Provider]          | [eclipse-tractusx/tractusx-edc](https://github.com/eclipse-tractusx/tractusx-edc)                                                                                                                                                                                                                            | CX - 0018                                                   |
+| EDC                   | Main gateaway to the network. In this use case two EDC need be existing, one connected to the Digital Product Pass (EcoPass KIT) [EDC Consumer] and another to the Provider Catena-X components [EDC Provider]          | [eclipse-tractusx/tractusx-edc](https://github.com/eclipse-tractusx/tractusx-edc)                                                                                                                                                                                                                            | CX - 0018   OR [Connector KIT](https://eclipse-tractusx.github.io/docs-kits/category/connector-kit)                                                    |
 | Digital Product Pass  | The [**EcoPass KIT**] reference implementation. The application responsible for retrieving the passports and interacting with the services listed above.                                                                | [eclipse-tractusx/digital-product-pass](https://github.com/eclipse-tractusx/digital-product-pass)                                                                                                                                                                                                            | CX - 0096                                                   |


The CX-Identifier (CX-0096) should be updated to "CX-0143" (Use Case Circular Economy - Digital Product Passport Standard 1.0.0) as the successor of CX-0096 in R24.05.

danielmiehle · 2024-05-24T06:44:24Z

Thanks for the updates. Can you please check the linting issues? We would like to merge the PR today.

matbmoser · 2024-05-24T07:04:42Z

Thanks for the updates. Can you please check the linting issues? We would like to merge the PR today.

On my way, forgot to push it... Ok it was wrong written:

matbmoser · 2024-05-24T07:05:29Z

Now it should be fine :)

matbmoser · 2024-05-24T07:06:50Z

Y'all are still failing the dash-licence and markdown-lint actions. Also, when building the website, there's a lot of warnings wrt to figures in the eco-pass-kit [1]. Is this addressed in this PR?

[1]

This is from adoption view no?
They are going to be addressed in this PR: #790

danielmiehle

LGTM - ready for merge!

matbmoser added 3 commits March 25, 2024 14:49

chore: updated table with kit references

cae5c92

chore: added single api retrival flow

3f7b7a6

Merge branch 'eclipse-tractusx:main' into ECO-Pass-KIT-Update-24.05-S…

d805cb5

…oftware-View

matbmoser added documentation Improvements or additions to documentation enhancement New feature or request labels Mar 25, 2024

matbmoser requested a review from LuisRickert March 25, 2024 17:19

matbmoser self-assigned this Mar 25, 2024

LuisRickert approved these changes Mar 26, 2024

View reviewed changes

LuisRickert added 4 commits March 26, 2024 13:29

chore: update changelog

4fd6dfa

chore: fix md linting

42806fa

chore: summarize changelog

be019e1

chore: update changelog

831724e

matbmoser marked this pull request as ready for review April 9, 2024 15:13

matbmoser and others added 4 commits April 9, 2024 17:16

Merge branch 'main' into ECO-Pass-KIT-Update-24.05-Software-View

e3aa651

chore(ecopass-kit): added add-ons that will be published in R24.05

41b2bfa

chore(ecopass-kit): updated changelog

afea152

chore(ecopass-kit): fixed missing details

6a7f1ac

matbmoser force-pushed the ECO-Pass-KIT-Update-24.05-Software-View branch from 1a5eb95 to 6a7f1ac Compare April 25, 2024 11:53

Mathias Brunkow Moser added 2 commits April 25, 2024 13:58

chore(ecopass-kit): corrected incorrect usage of policy and digital twin

80d198f

chore(ecopass-kit): updated changelog

4b9e467

Merge branch 'eclipse-tractusx:main' into ECO-Pass-KIT-Update-24.05-S…

15f83cb

…oftware-View

arnoweiss reviewed May 7, 2024

View reviewed changes

LuisRickert mentioned this pull request May 14, 2024

[ECO-Pass KIT] Release Checks eclipse-tractusx/sig-release#656

Closed

19 tasks

HFocken suggested changes May 15, 2024

View reviewed changes

danielmiehle previously approved these changes May 15, 2024

View reviewed changes

fix: adjust release name

b2cb6f9

LuisRickert dismissed danielmiehle’s stale review via b2cb6f9 May 15, 2024 16:34

chore: added link to dpp-tutorial in the kit

5493922

HFocken approved these changes May 23, 2024

View reviewed changes

jSchuetz88 approved these changes May 24, 2024

View reviewed changes

chore: fixed link typo

f7c349e

matbmoser requested review from danielmiehle and maximilianong May 24, 2024 07:18

danielmiehle approved these changes May 24, 2024

View reviewed changes

maximilianong approved these changes May 24, 2024

View reviewed changes

maximilianong merged commit e7fe342 into eclipse-tractusx:main May 24, 2024
5 checks passed

LuisRickert deleted the ECO-Pass-KIT-Update-24.05-Software-View branch June 10, 2024 16:39

matbmoser linked an issue Jul 5, 2024 that may be closed by this pull request

Release KIT 24.05 eclipse-tractusx/digital-product-pass#358

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docs(ecopass-kit): Updated the EcoPass KIT Software Development View #791

docs(ecopass-kit): Updated the EcoPass KIT Software Development View #791

matbmoser commented Mar 25, 2024 •

edited

Loading

matbmoser commented Apr 25, 2024

arnoweiss May 7, 2024

LuisRickert May 8, 2024

matbmoser May 17, 2024

HFocken left a comment

HFocken May 15, 2024

LuisRickert May 15, 2024

danielmiehle left a comment

matbmoser commented May 17, 2024

HFocken left a comment

arnoweiss commented May 23, 2024

jSchuetz88 left a comment

jSchuetz88 May 24, 2024

matbmoser May 24, 2024

danielmiehle commented May 24, 2024

matbmoser commented May 24, 2024 •

edited

Loading

matbmoser commented May 24, 2024

matbmoser commented May 24, 2024 •

edited

Loading

danielmiehle left a comment

docs(ecopass-kit): Updated the EcoPass KIT Software Development View #791

docs(ecopass-kit): Updated the EcoPass KIT Software Development View #791

Conversation

matbmoser commented Mar 25, 2024 • edited Loading

Why do we create this PR?

What we want to achieve with this PR?

What's new?

Added

Pre-review checks

matbmoser commented Apr 25, 2024

arnoweiss May 7, 2024

Choose a reason for hiding this comment

LuisRickert May 8, 2024

Choose a reason for hiding this comment

matbmoser May 17, 2024

Choose a reason for hiding this comment

HFocken left a comment

Choose a reason for hiding this comment

HFocken May 15, 2024

Choose a reason for hiding this comment

LuisRickert May 15, 2024

Choose a reason for hiding this comment

danielmiehle left a comment

Choose a reason for hiding this comment

matbmoser commented May 17, 2024

HFocken left a comment

Choose a reason for hiding this comment

arnoweiss commented May 23, 2024

jSchuetz88 left a comment

Choose a reason for hiding this comment

jSchuetz88 May 24, 2024

Choose a reason for hiding this comment

matbmoser May 24, 2024

Choose a reason for hiding this comment

danielmiehle commented May 24, 2024

matbmoser commented May 24, 2024 • edited Loading

matbmoser commented May 24, 2024

matbmoser commented May 24, 2024 • edited Loading

danielmiehle left a comment

Choose a reason for hiding this comment

matbmoser commented Mar 25, 2024 •

edited

Loading

matbmoser commented May 24, 2024 •

edited

Loading

matbmoser commented May 24, 2024 •

edited

Loading