Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(conn): Fix two typos in connector kit #848

Merged
merged 1 commit into from
May 3, 2024

Conversation

lgblaumeiser
Copy link
Contributor

Description

Reading through the connector kit I found two typos which I fixed with this pull request

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@lgblaumeiser lgblaumeiser changed the title doc: Fix two typos in connector kit doc(conn): Fix two typos in connector kit Apr 16, 2024
@arnoweiss
Copy link
Contributor

arnoweiss commented Apr 16, 2024

edit: added footnote.

Can you redirect this PR to this PRs head branch [1]? Then we'll avoid merge conflicts on main and resolve the dash-check.

[1] #792

@lgblaumeiser
Copy link
Contributor Author

Hi @arnoweiss , what exactly are you referring to? You refer to a footnote, which is not resolved.

@lgblaumeiser
Copy link
Contributor Author

Hi @arnoweiss, tried that, issue is, that your branch is quite old and this adds 108 commits to my commit. I do not see a merge conflict, as your changes in the files I have adapted are in different places and git should be able to merge that without a conflict.

@lgblaumeiser
Copy link
Contributor Author

@stephanbcbauer, can you advice me, whether I need to do something to get a review? And a hint, what I can do, to get also the failing check to a success. Thanks!

@arnoweiss
Copy link
Contributor

arnoweiss commented Apr 18, 2024

The check is failing because the DEPENDENCIES file isn't updated properly. It's an eclipse foundation requirement. To solve:

  1. Download Eclipse dash jar from here.
  2. Execute with adjusted paths (depending on where you downloaded the jar to and where package-lock.json and the DEPENDENCIES file are (project root).
java -jar ./org.eclipse.dash.licenses-1.1.0.jar package-lock.json -project automotive.tractusx -includeScope=test -summary ./DEPENDENCIES
  1. commit the changes and push.
  2. Pray to heaven that the pipeline passes (I've witnessed some entirely nondeterministic behavior when working on tractusx-edc)

@lgblaumeiser
Copy link
Contributor Author

Dash tooling runs through locally without an issue, error message of check shows a return value 429 indicating too many requests, so I assume, that the check is not broken. Cannot restart the check, though.

Signed-off-by: Lars Geyer-Blaumeiser <[email protected]>
Copy link
Contributor

@maximilianong maximilianong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for correcting the typos :)

Copy link
Member

@stephanbcbauer stephanbcbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lgblaumeiser
Copy link
Contributor Author

@stephanbcbauer @maximilianong Thanks for the reviews!

Would you be so kind and merge the PR?

@stephanbcbauer stephanbcbauer merged commit bcddc25 into eclipse-tractusx:main May 3, 2024
5 checks passed
@lgblaumeiser lgblaumeiser deleted the fix_typos branch June 14, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants