-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc(conn): Fix two typos in connector kit #848
Conversation
edit: added footnote.Can you redirect this PR to this PRs head branch [1]? Then we'll avoid merge conflicts on main and resolve the dash-check. [1] #792 |
Hi @arnoweiss , what exactly are you referring to? You refer to a footnote, which is not resolved. |
Hi @arnoweiss, tried that, issue is, that your branch is quite old and this adds 108 commits to my commit. I do not see a merge conflict, as your changes in the files I have adapted are in different places and git should be able to merge that without a conflict. |
@stephanbcbauer, can you advice me, whether I need to do something to get a review? And a hint, what I can do, to get also the failing check to a success. Thanks! |
The check is failing because the
java -jar ./org.eclipse.dash.licenses-1.1.0.jar package-lock.json -project automotive.tractusx -includeScope=test -summary ./DEPENDENCIES
|
Dash tooling runs through locally without an issue, error message of check shows a return value 429 indicating too many requests, so I assume, that the check is not broken. Cannot restart the check, though. |
Signed-off-by: Lars Geyer-Blaumeiser <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for correcting the typos :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@stephanbcbauer @maximilianong Thanks for the reviews! Would you be so kind and merge the PR? |
Description
Reading through the connector kit I found two typos which I fixed with this pull request
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: