-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add TRG for UX/UI styleguide #865
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jjeroch thanks for the work,
i personally would leave out the checkbox style within the TRG but would take it as a little tasklist for the Release guideline checks... or implement this within our PR template.
Then within the TRG it is clear what to consider is a must or be aware of the styleguide.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quality or Release Gateways are not confirmed for the future process; I therefore propose some wording updates to enable the check of the UI/UX criteria upon releasing a new GitHub version of any app with user interface
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for providing! The TRG often refers to a styleguide for which I'm not sure which link actually must be handled as. For more explanations, please refer to the comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, reframing makes it more understandable!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I have added my comments, I believe if we specify more on "what should be there" and "what should be not there" it would be more precise.
Like a "Do’s and don’ts" section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work and team effort, thanks for the work LGTM
Thanks for the good feedback, just the idea was to transfer the previous state of the styleguide without any new requirements, I suggest to open an update pull request to the TRG once this has been merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, wonderful job!
Description
add TRG for UX/UI styleguide
Pre-review checks