feat: simplify negotiation and transfer handling #155
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| ENV OTEL_AGENT_LOCATION "https://github.com/open-telemetry/opentelemetry-java-instrumentation/releases/download/v1.12.1/opentelemetry-javaagent.jar" | ||
|
|
||
| HEALTHCHECK NONE | ||
|
|
||
| RUN apk update && apk add curl=8.4.0-r0 --no-cache | ||
| RUN apk update && apk add curl --no-cache |
Check warning
Code scanning / KICS
Unpinned Package Version in Apk Add Warning
|
|
||
| ENV OTEL_AGENT_LOCATION "https://github.com/open-telemetry/opentelemetry-java-instrumentation/releases/download/v1.12.1/opentelemetry-javaagent.jar" | ||
|
|
||
| HEALTHCHECK NONE | ||
|
|
||
| RUN apk update && apk add curl=8.4.0-r0 --no-cache | ||
| RUN apk update && apk add curl --no-cache |
Check warning
Code scanning / KICS
Unpinned Package Version in Apk Add Warning
|
Since the EDRs should be explicitely deleted (as they would restart transfers until the end of the agreement period), we currently refrain from using them as the main tool for KA. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Simplifies the negotiation and transfer handling by switching to the TX EDC's EDR api. Makes exposing of a callback interface and the corresponding configuration redundant.
WHY
EDR engine with single polling on the EDR is faster than two asynchronous processes (negotiation + transfer) with callback.
FURTHER NOTES
Closes #96 <-- insert Issue number if one exists