updates(eslint): enable require-await rule (#393)

eclipse-tractusx · Dec 5, 2023 · 5370703 · 5370703
1 parent bda2267
commit 5370703
Show file tree

Hide file tree

Showing 9 changed files with 15 additions and 13 deletions.
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -51,7 +51,6 @@
         "@typescript-eslint/no-unnecessary-type-assertion": 0,
         "@typescript-eslint/prefer-includes": 0,
         "@typescript-eslint/promise-function-async": 0,
-        "@typescript-eslint/require-await": 0,
         "@typescript-eslint/restrict-plus-operands": 0,
         "@typescript-eslint/triple-slash-reference": 0,
         "@typescript-eslint/unbound-method": 0,

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -17,6 +17,7 @@
 - Overlays
   - Change Overlay Button from "Cancel" to "Close"
 - ESLINT
+  - Enable require-await rule
   - Enable return-await rule
   - Enable prefer-reduce-type-parameter rule
   - Enable prefer-readonly rule

diff --git a/src/components/overlays/AddAppUserRoles/index.tsx b/src/components/overlays/AddAppUserRoles/index.tsx
@@ -57,7 +57,7 @@ export default function AddAppUserRoles() {
   const [activeStep, setActiveStep] = useState(1)
   const [updateUserRoles] = useUpdateUserRolesMutation()
 
-  const handleConfirm = async () => {
+  const handleConfirm = () => {
     if (!appId || !users || roles.length <= 0) return
 
     users.map(async (user) => {
@@ -162,7 +162,9 @@ export default function AddAppUserRoles() {
             </Button>
             <Button
               variant="contained"
-              onClick={() => handleConfirm()}
+              onClick={() => {
+                handleConfirm()
+              }}
               disabled={!users || roles.length <= 0}
             >
               {t('content.addUserRight.confirmSelectedRoles')}

diff --git a/src/components/overlays/AddMultipleUser/index.tsx b/src/components/overlays/AddMultipleUser/index.tsx
@@ -169,15 +169,15 @@ export default function AddMultipleUser() {
     }
   }
 
-  const handleConfirm = async () => {
+  const handleConfirm = () => {
     if (isSuccess || isError) dispatch(closeOverlay())
     if (uploadedFile && !roles.length) setIsFileUploaded(true)
     else if (uploadedFile && roles.length) {
       setLoading(true)
       uploadedFile &&
         Papa.parse(uploadedFile, {
           skipEmptyLines: true,
-          complete: async (results) => {
+          complete: (results) => {
             const csvData: Array<Array<string>> = results.data as Array<
               Array<string>
             >
@@ -192,7 +192,7 @@ export default function AddMultipleUser() {
     }
   }
 
-  const onChangeFile = async (selectedFile: File) => {
+  const onChangeFile = (selectedFile: File) => {
     setUploadedFile(undefined)
     Papa.parse(selectedFile, {
       skipEmptyLines: true,

diff --git a/src/components/pages/AppOverview/AddRoles.tsx b/src/components/pages/AppOverview/AddRoles.tsx
@@ -78,7 +78,7 @@ export default function AddRoles() {
     refetch()
   }, [state])
 
-  const handleSaveClick = async () => {
+  const handleSaveClick = () => {
     setIsLoading(true)
   }
 

diff --git a/src/components/pages/AppOverview/ChangeDocuments.tsx b/src/components/pages/AppOverview/ChangeDocuments.tsx
@@ -88,7 +88,7 @@ export default function ChangeDocuments() {
     await updateAppChangeDocument(data).unwrap()
   }
 
-  const onFileUpload = async (file: DropzoneFile) => {
+  const onFileUpload = (file: DropzoneFile) => {
     if (appId && file) {
       const setFileStatus = (status: UploadStatus) => {
         setValue('uploadDocument', {

diff --git a/src/components/pages/AppOverview/ChangeImage.tsx b/src/components/pages/AppOverview/ChangeImage.tsx
@@ -106,7 +106,7 @@ export default function ChangeImage() {
   const uploadImageValue = getValues()
     .uploadLeadImage as unknown as DropzoneFile
 
-  const handleSaveClick = async () => {
+  const handleSaveClick = () => {
     setIsLoading(true)
     if (appId && uploadImageValue) {
       const setFileStatus = (status: UploadFileStatus) => {

diff --git a/src/components/pages/IDPManagement/IDPList.tsx b/src/components/pages/IDPManagement/IDPList.tsx
@@ -53,7 +53,7 @@ const MenuItemOpenOverlay = ({
 }) => {
   const dispatch = useDispatch()
 
-  const openOverlay = async (
+  const openOverlay = (
     e: React.MouseEvent<HTMLElement, MouseEvent>,
     overlay: OVERLAYS,
     id: string
@@ -68,9 +68,9 @@ const MenuItemOpenOverlay = ({
 
   return (
     <MenuItem
-      onClick={(e: React.MouseEvent<HTMLElement, MouseEvent>) =>
+      onClick={(e: React.MouseEvent<HTMLElement, MouseEvent>) => {
         openOverlay(e, overlay, id)
-      }
+      }}
     >
       {label}
     </MenuItem>

diff --git a/src/components/pages/NotificationCenter/NotificationItem.tsx b/src/components/pages/NotificationCenter/NotificationItem.tsx
@@ -249,7 +249,7 @@ export default function NotificationItem({
     setUserRead(item.userRead)
   }, [item.userRead])
 
-  const toggle = async () => {
+  const toggle = () => {
     const nextState = !open
     if (nextState && !userRead) {
       setUserRead(true)