updates(eslint): enable dot-notations rule (#377)

eclipse-tractusx · Nov 28, 2023 · 56cf61d · 56cf61d
1 parent 4252b89
commit 56cf61d
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 4 deletions.
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -43,7 +43,6 @@
         "@typescript-eslint/consistent-indexed-object-style": 0,
         "@typescript-eslint/consistent-type-assertions": 0,
         "@typescript-eslint/consistent-type-definitions": 0,
-        "@typescript-eslint/dot-notation": 0,
         "@typescript-eslint/no-base-to-string": 0,
         "@typescript-eslint/no-floating-promises": 0,
         "@typescript-eslint/no-inferrable-types": 0,

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -9,6 +9,8 @@
   - Document Hover Effect
 - Tech User Details
   - Fix crash issue
+- ESLINT
+  - Enable dot-notation rule
 - User management
   - Updated app access management flow
 - Overlays

diff --git a/src/components/overlays/AddBPN/index.tsx b/src/components/overlays/AddBPN/index.tsx
@@ -83,7 +83,7 @@ export default function AddBPN({ id }: { id: string }) {
   }
 
   const onDeleteBpnHandler = (deleteBpnId: string) => {
-    const params = { companyUserId: stateSelectorInfo['id'], bpn: deleteBpnId }
+    const params = { companyUserId: stateSelectorInfo.id, bpn: deleteBpnId }
     dispatch(deleteUserBpn(params))
   }
 

diff --git a/src/features/apps/marketplaceDeprecated/slice.ts b/src/features/apps/marketplaceDeprecated/slice.ts
@@ -31,6 +31,10 @@ import {
 } from './types'
 import { appToCard } from '../mapper'
 
+enum Status {
+  ACTIVE = 'ACTIVE',
+}
+
 export const slice = createSlice({
   name,
   initialState,
@@ -114,8 +118,7 @@ export const subscribedAppsSelector = (state: RootState) =>
       return state.apps.marketplace.subscribedApps.find(
         (app: SubscribedApps) => {
           return (
-            item['id'] === app['appId'] &&
-            app['appSubscriptionStatus'] === 'ACTIVE'
+            item.id === app.appId && app.appSubscriptionStatus === Status.ACTIVE
           )
         }
       )