fix: Retain "None" Option in Technical User Setup After Submission #1039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s, This will Resolve the issue of selection.
ss-nikunj
changed the title
oyo
requested changes
Sep 6, 2024
| // Set default value as "None" when user profiles don't have any roles | ||
| // Initially, value is "None" | ||
| setTechUserProfiles([technicalUserNone]) | ||
| } |
There was a problem hiding this comment.
better use ? : instead of if-else here:
setTechUserProfiles(userProfiles.length > 0 ? userProfiles : [technicalUserNone])
There was a problem hiding this comment.
Hi @oyo,
I am using the if and else statements because of easy to read and understand the code. Sometimes ?: will create an issue.
But anyway I will make these changes. 🙂
manojava-gk
reviewed
Sep 9, 2024
CHANGELOG.md
Outdated
| @@ -100,6 +100,7 @@ | |||
| - fixed height for "Admin Service Detail" page content [#1001](https://github.com/eclipse-tractusx/portal-frontend/pull/1001) | |||
| - fixed onClick of "Overview My Apps" button in App Release Process screen [#1022](https://github.com/eclipse-tractusx/portal-frontend/issues/1022) | |||
| - Fix 400 Bad Request error in App Access Management -> Add Role search filter [#1057](https://github.com/eclipse-tractusx/portal-frontend/issues/1057) | |||
| - fixed "None" selection issue in Technical Integration -> App Release Process [#1036](https://github.com/eclipse-tractusx/portal-frontend/issues/1036) | |||
There was a problem hiding this comment.
this has been added in the wrong place. Put this at the top.
title should be "unreleased"
|
|
Hi @oyo & @manojava-gk, I have covered your feedback, Can you review it again? 🙂 |
oyo
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ifcondition inuseEffectto verify if the user has assigned roles. If no roles are found, the "None" option is automatically selected.Why
Issue
Github Issue: #1036
Checklist
REC-20240827121521.mp4