Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: subscription detail page for customer #1051

Merged

Conversation

charmi-v
Copy link
Contributor

Description

Enhanced the Subscribed Detail Page for customer :

  • Improved the App Information section with subscribed app details (including images, language, documents, and privacy).
  • Added Technical User Details with a link to user details, visible to users with the view_tech_user_management role.
  • Optimized responsiveness for mobile, tablet, and full display screens.

Preview
LargeScreen

Why

Extended the subscription detail page to include more comprehensive app-related information.

Issue

#939

Checklist

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@charmi-v charmi-v marked this pull request as draft August 29, 2024 05:54
@charmi-v charmi-v marked this pull request as ready for review August 29, 2024 05:55
@manojava-gk
Copy link
Contributor

optimise and create common file to reduce duplication issue

@charmi-v
Copy link
Contributor Author

@manojava-gk I have optimized the code block that appeared duplicated in failing action check

  • However, the SonarCloud analysis has not been triggered for this new commit, and the analysis still reflects the code from the previous commit.
  • Could you please advise on how to trigger the SonarCloud code analysis action for the latest commit within the same pull request?

@manojava-gk
Copy link
Contributor

@manojava-gk I have optimized the code block that appeared duplicated in failing action check

  • However, the SonarCloud analysis has not been triggered for this new commit, and the analysis still reflects the code from the previous commit.
  • Could you please advise on how to trigger the SonarCloud code analysis action for the latest commit within the same pull request?

As per the PR and sonar cloud dashboard, it has run on your recent commit(c9beed8)not the old.

@charmi-v
Copy link
Contributor Author

@manojava-gk I have optimized the code block that appeared duplicated in failing action check

  • However, the SonarCloud analysis has not been triggered for this new commit, and the analysis still reflects the code from the previous commit.
  • Could you please advise on how to trigger the SonarCloud code analysis action for the latest commit within the same pull request?

As per the PR and sonar cloud dashboard, it has run on your recent commit(c9beed8)not the old.

@manojava-gk Issue resolved now

@manojava-gk
Copy link
Contributor

@charmi-v Kindly fix the issues from sonar cloud. Pretty straight forward.

@charmi-v
Copy link
Contributor Author

@charmi-v Kindly fix the issues from sonar cloud. Pretty straight forward.

@manojava-gk Resolved

Copy link
Contributor

@manojava-gk manojava-gk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lftm. But add notes in CHANGELOG.md file

@charmi-v
Copy link
Contributor Author

charmi-v commented Sep 2, 2024

lftm. But add notes in CHANGELOG.md file

Updated the description in CHANGELOG.md file

oyo
oyo previously approved these changes Sep 6, 2024
Copy link

sonarqubecloud bot commented Sep 6, 2024

@oyo oyo merged commit 35f03e3 into eclipse-tractusx:main Sep 6, 2024
8 checks passed
@evegufy evegufy added this to the Release 24.12 milestone Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: USER READY
Development

Successfully merging this pull request may close these issues.

4 participants