Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update user management filters for emails with special characters #1129

Merged
merged 12 commits into from
Oct 16, 2024
Merged

fix: update user management filters for emails with special characters #1129

merged 12 commits into from
Oct 16, 2024

Conversation

ss-nikunj
Copy link
Contributor

@ss-nikunj ss-nikunj commented Sep 19, 2024 •
edited
Loading

Description

This PR fixes an issue where the user management filters were not working for email addresses containing special characters like + . Examples of problematic emails include:

  • [email protected]

  • [email protected]

  • App Access Management -> Add Role -> User List
    App Access Management -> Add Role -> User List have same special character (+) related issue on search input.

Why

  • Updated the email filter logic to correctly handle special characters such as +.

Issue

Checklist

  • I have followed the contributing guidelines
  • I have created and linked IP issues or requested their creation by a committer
  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have checked that new and existing tests pass locally with my changes

image
image

@ss-nikunj ss-nikunj marked this pull request as draft September 19, 2024 07:30
JordanGerada3
JordanGerada3 reviewed Sep 19, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@JordanGerada3 JordanGerada3 self-requested a review September 19, 2024 07:42
@ss-nikunj ss-nikunj marked this pull request as ready for review September 19, 2024 09:28
JordanGerada3
JordanGerada3 approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@JordanGerada3 JordanGerada3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

locally tested, works good!

manojava-gk
manojava-gk suggested changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@manojava-gk manojava-gk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move regex to patterns file

src/components/shared/frame/UserList/index.tsx Outdated Show resolved Hide resolved
@ss-nikunj
Copy link
Contributor Author

Hi @manojava-gk,
As per your suggestions I have moved Search email regex into Patterns file. Can you please review it again.

Thank you!

@ss-nikunj
Copy link
Contributor Author

Move regex to patterns file

Hello @manojava-gk,

Regex moved into Patterns file and I have added testcases for this newly added pattern. Can you please review it again.

Thank you!!

@evegufy evegufy added this to the Release 24.12 milestone Oct 9, 2024
@evegufy evegufy changed the title fix: User management filters for emails with special characters fix: update user management filters for emails with special characters Oct 9, 2024
@evegufy
Copy link
Contributor

evegufy commented Oct 9, 2024

@manojava-gk could you please review again?

manojava-gk
manojava-gk approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@manojava-gk manojava-gk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

oyo
oyo requested changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@oyo oyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small change

src/components/shared/frame/UserList/index.tsx Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ss-nikunj
Copy link
Contributor Author

Hi @oyo, I made a changes according to your feedback. Please review it again.

@ss-nikunj ss-nikunj requested a review from oyo October 11, 2024 11:55
@oyo oyo merged commit 0b66dca into eclipse-tractusx:main Oct 16, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JordanGerada3 JordanGerada3 JordanGerada3 approved these changes

@manojava-gk manojava-gk manojava-gk approved these changes

@oyo oyo oyo approved these changes

@isaadansari isaadansari Awaiting requested review from isaadansari

@typecastcloud typecastcloud Awaiting requested review from typecastcloud

@shubhamv-ss shubhamv-ss Awaiting requested review from shubhamv-ss

@nidhigarg-bmw nidhigarg-bmw Awaiting requested review from nidhigarg-bmw

@lavanya-bmw lavanya-bmw Awaiting requested review from lavanya-bmw

Assignees

@manojava-gk manojava-gk

Labels
None yet
Projects
Portal
Status: USER READY
Milestone
Release 2.3.0 (24.12)
Development

Successfully merging this pull request may close these issues.
6 participants
@ss-nikunj @evegufy @oyo @manojava-gk @JordanGerada3 @typecastcloud