Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): fix dom nesting #1435

Merged
merged 1 commit into from
Jan 20, 2025
Merged

fix(react): fix dom nesting #1435

merged 1 commit into from
Jan 20, 2025

Conversation

oyo
Copy link
Contributor

@oyo oyo commented Jan 17, 2025

Description

Fix dom where div appears as a child of p

Why

According to the HTML specification the p element must only contain "Phrasing Content" while div is not permitted: https://html.spec.whatwg.org/multipage/grouping-content.html#the-p-element
(Typography is rendered to p and StatusTag rendered to a div)

Issue

#1269

Checklist

Please delete options that are not relevant.

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally

@oyo oyo requested a review from evegufy January 17, 2025 06:58
@evegufy evegufy added this to the Release 25.03 milestone Jan 17, 2025
@oyo oyo merged commit daa5b50 into main Jan 20, 2025
8 checks passed
@oyo oyo deleted the fix/1269/dom-nesting branch January 20, 2025 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: USER READY
Development

Successfully merging this pull request may close these issues.

2 participants