Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(connector): show error component #903

Closed
wants to merge 1 commit into from
Closed

fix(connector): show error component #903

wants to merge 1 commit into from

Conversation

manojava-gk
Copy link
Contributor

@manojava-gk manojava-gk commented Jul 3, 2024 •
edited
Loading

Description

show appropriate error component based on response status

Why

error handling functionality is missing

Issue

#758

Checklist

Please delete options that are not relevant.

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@manojava-gk manojava-gk marked this pull request as ready for review July 3, 2024 09:36
@manojava-gk manojava-gk requested review from lavanya-bmw and oyo July 3, 2024 09:36
lavanya-bmw
lavanya-bmw approved these changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@lavanya-bmw lavanya-bmw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

evegufy
evegufy requested changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the issue #758 is marked for the 2.1.0 release, please change to release branch

@manojava-gk manojava-gk marked this pull request as draft July 5, 2024 06:35
@manojava-gk manojava-gk changed the base branch from main to release/v2.1.0-RC1 July 5, 2024 06:35
@manojava-gk manojava-gk changed the base branch from release/v2.1.0-RC1 to main July 5, 2024 06:36
@manojava-gk
Copy link
Contributor Author

Created new PR and change base to release branch

@manojava-gk manojava-gk closed this Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evegufy evegufy evegufy requested changes

@lavanya-bmw lavanya-bmw lavanya-bmw approved these changes

@oyo oyo Awaiting requested review from oyo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@manojava-gk @evegufy @lavanya-bmw