Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(semantic hub): display error bar #917

Conversation

lavanya-bmw
Copy link
Contributor

@lavanya-bmw lavanya-bmw commented Jul 11, 2024

Description

Show appropriate error information to the user along with reload

Why

To enhance error handling

Issue

#891

Checklist

Please delete options that are not relevant.

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally

@lavanya-bmw lavanya-bmw requested review from oyo and manojava-gk July 11, 2024 06:44
@lavanya-bmw lavanya-bmw marked this pull request as draft July 12, 2024 04:59
@evegufy evegufy changed the base branch from release/v2.1.0-RC1 to release/v2.1.0-RC2 July 12, 2024 15:35
@lavanya-bmw lavanya-bmw marked this pull request as ready for review July 15, 2024 11:00
if (error) {
errorObj.status = Number(error)
errorObj.message =
error && Number(error) >= 400 && Number(error) < 500

Check warning

Code scanning / CodeQL

Useless conditional Warning

This use of variable 'error' always evaluates to true.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Copy link
Contributor

@manojava-gk manojava-gk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@oyo oyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments about how to get rid of any type

src/features/semanticModels/types.ts Outdated Show resolved Hide resolved
src/features/semanticModels/actions.ts Outdated Show resolved Hide resolved
src/features/semanticModels/actions.ts Outdated Show resolved Hide resolved
@lavanya-bmw lavanya-bmw requested a review from oyo July 17, 2024 08:06
@evegufy evegufy changed the base branch from release/v2.1.0-RC2 to release/v2.1.0-RC3 July 17, 2024 14:38
@lavanya-bmw lavanya-bmw requested a review from manojava-gk July 18, 2024 07:07
@oyo oyo merged commit 7d46955 into eclipse-tractusx:release/v2.1.0-RC3 Jul 22, 2024
7 checks passed
@oyo oyo deleted the fix/891/semantic-hub-error-handling branch July 22, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants