-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(role): typo fix for the role to hide admin board page for service manager #937
fix(role): typo fix for the role to hide admin board page for service manager #937
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank for the contributions!
could you please solve the conflict with the changelog file?
Please also update the dependencies file (you can download the artifact here and commit the updated file https://github.com/eclipse-tractusx/portal-frontend/actions/runs/9956456758?pr=937)
In general, it would be great if you could not link to closed systems like your entry "entry" environment, such an example link is much more friendly in the open: https://portal-backend.example.org/api/services/serviceRelease/inReview?size=15&page=0&status=InReview&sorting=DateDesc
As maintainer you should have the ability to modify the PR. We don't. This is his personal fork and no one else has access. Sorry. @oyo already added a commit |
Quality Gate passedIssues Measures |
Description
Current Behavior
Service Management -> Admin Board page is not showing the Services and responding 403 Forbidden error.
Expected Behavior
Service Manager should be able to see services list on Admin Board page OR Service Manager should not see Admin Board sub-menu option under Service Management menu if Service Manager doesn't supposed to have related permissions.
Steps To Reproduce
Findings
Service Management -> Admin Board page is calling the API: https://portal-backend.entry.cofinity-x.com/api/services/serviceRelease/inReview?size=15&page=0&status=InReview&sorting=DateDesc
and this API has following permissions:
but Service Manager user account doesn’t have such permissions.
Why
In frontend these are the following roles:
APPROVE_SERVICE_RELEASE = 'activate_subscription'
DECLINE_SERVICE_RELEASE = 'decline_service_release'
So, the issue seems to be at the frontend side that APPROVE_SERVICE_RELEASE variable as wrong role value (activate_subscription) which needs to be corrected by approve_service_release value so, that this Admin Board page would only be visible to the users who would have same roles as API roles.
Issue
#936
Checklist