fix(company data): update company data input patterns #946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manojava-gk
changed the base branch from
release/v2.1.0-RC3
to
release/v2.1.0-RC2
manojava-gk
changed the base branch from
release/v2.1.0-RC2
to
release/v2.1.0-RC3
manojava-gk
force-pushed
the
fix/issues-894-patterns
branch
from
788423e to
12be7b3
Compare
oyo
requested changes
Jul 22, 2024
| label={ | ||
| isAddress | ||
| ? t('content.companyData.address.form.site.name') | ||
| : t('content.companyData.site.form.site.name') |
There was a problem hiding this comment.
I'd suggest to write all those more compact as
label={t('content.companyData.${isAddress ? 'address' : 'site'}.form.site.name')}
(replace outer ' with ` )
|
oyo
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
update company data input patterns
Why
should be in sync with registration repo
Issue
#894
Checklist
Please delete options that are not relevant.