Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(subscription details): implement loader for subscription #959

Conversation

kunalgaurav-bmw
Copy link
Contributor

@kunalgaurav-bmw kunalgaurav-bmw commented Jul 23, 2024

Description

implement loading state for provider subscription detail overlay

Why

When accessing the provider subscription detail view and initiating the detail overlay, the UI currently pre-fills data fields with "n/a" before the backend has completed fetching the data. So, loader is needed

Issue

#922

Checklist

Please delete options that are not relevant.

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally

Copy link

Copy link
Contributor

@oyo oyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me :)

@oyo oyo merged commit d6db4f1 into eclipse-tractusx:main Jul 23, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants