Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loki: C transpilation from pipeline in config file #106

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

mlange05
Copy link
Collaborator

@mlange05 mlange05 commented Dec 24, 2024

This PR adds a new C-transpilation pipeline to the Loki configuration file that replaces the previous use of the implicit entry point for the FortranCTransformation in loki-transform.py convert. It does this by adding a new entry for the FortranISOCWrapperTransformation and marking the corresponding modules with "header" roles.

Integration note: This PR requires Loki PR #464 (ecmwf-ifs/loki#464) to be merged first, and currently points to this branch in a temporary head commit that should be removed before merging.

@mlange05 mlange05 requested a review from reuterbal December 24, 2024 04:20
@mlange05 mlange05 force-pushed the naml-loki-c-pipeline branch from c464088 to 5658cb3 Compare January 9, 2025 15:42
@mlange05 mlange05 marked this pull request as ready for review January 9, 2025 16:33
Copy link
Collaborator

@reuterbal reuterbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :shipit:

@reuterbal reuterbal merged commit 62963b2 into develop Jan 9, 2025
32 checks passed
@reuterbal reuterbal deleted the naml-loki-c-pipeline branch January 9, 2025 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants