-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow GPU version to compile with OpenMP #180
Open
samhatfield
wants to merge
16
commits into
ecmwf-ifs:develop
Choose a base branch
from
samhatfield:refresh_openmp
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+229
−195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now we can at least run the configure with OpenMP enabled.
samhatfield
force-pushed
the
refresh_openmp
branch
from
December 30, 2024 10:04
dfd28fc
to
f9158af
Compare
samhatfield
commented
Jan 15, 2025
!$OMP END TARGET DATA | ||
#endif | ||
#ifdef ACCGPU | ||
!$ACC end data |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
!$ACC end data | |
!$ACC END DATA |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR permits us to build ecTrans for GPUs using OpenMP offload. It is not even remotely working yet. Here I've just done all the work necessary to run a simple test program:
I plan to add support for OpenMP offload gradually such that we can eventually run the full benchmark program. This PR is the first step.
I've also taken the opportunity to tidy up
SETUP_TRANS
.