Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for ifs-bundle CY49R1.0 #11

Merged
merged 13 commits into from
Mar 19, 2024
Merged

Prepare for ifs-bundle CY49R1.0 #11

merged 13 commits into from
Mar 19, 2024

Conversation

awnawab
Copy link
Contributor

@awnawab awnawab commented Mar 18, 2024

This PR prepares ecWAM for extraction from ifs-source/contrib to the ifs-bundle. It comprises mainly of changes to how compiler flags are set, as these will no longer be inherited from ifs-source. There are also a few more changes picked from ifs-source that were added after the last sync and before 49r1.0 was declared. Finally, there is a change to the ocean model coupling mechanism, as the library names were no longer inherited from ifs-source.

@FussyDuck
Copy link

FussyDuck commented Mar 18, 2024

CLA assistant check
All committers have signed the CLA.

@awnawab awnawab requested a review from wdeconinck March 18, 2024 08:50
Copy link
Collaborator

@wdeconinck wdeconinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks for this tedious work

@awnawab
Copy link
Contributor Author

awnawab commented Mar 19, 2024

Hi @dawson-ec. Could you please sign the CLA? This PR contains one of your commits cherry-picked from ifs-source.

@wdeconinck wdeconinck merged commit 71bcfdd into main Mar 19, 2024
9 checks passed
@awnawab awnawab deleted the naan-ifs-bundle-prepare branch March 25, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants