Port remaining 49R2 science contributions #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jrbidlot and @jkousal32 could you please check that I have not missed anything here or made a mistake whilst porting? The 50R1 science contributions in IFS-3455 have also been ported, and that PR will be filed on top of this once this is merged. |
cxzk
approved these changes
Dec 19, 2024
jkousal32
approved these changes
Dec 19, 2024
jrbidlot
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports over the 49R2 science contributions pertaining to the wave model in tickets IFS-3385, IFS-3522 and IFS-3792. There is also a small bugfix in
WAVEMDLfor bounds checking in nvhpc debug builds.Many thanks to @cxzk for confirming this branch is bit-identical in the CI suite.
NB: please ignore the failing hpc-ci tests, that's due to a known permissions issue.