Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configs for finer grids #5

Merged
merged 6 commits into from
Nov 17, 2023
Merged

Add configs for finer grids #5

merged 6 commits into from
Nov 17, 2023

Conversation

awnawab
Copy link
Contributor

@awnawab awnawab commented Oct 16, 2023

This PR adds configs, including validation norms, for O640 and O1280 grids. A small fix to the ecwam runner script, needed to run the O1280 config, is also included.

@awnawab awnawab requested a review from wdeconinck October 16, 2023 07:39
@awnawab
Copy link
Contributor Author

awnawab commented Nov 10, 2023

Hi @wdeconinck. I implemented the changes you requested, this is ready for review again.

Copy link
Collaborator

@wdeconinck wdeconinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All great work. Thanks @awnawab!

@wdeconinck wdeconinck merged commit 053bb8a into main Nov 17, 2023
8 checks passed
@awnawab awnawab deleted the naan-fine-grid-configs branch December 18, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants