TransformInline: Fix rescoping in expression substitution #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This would otherwise in-place update associate statements, as they are type definitions. This would create issues for replicated calls when symbols are not rescoped properly.
|
Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/170/index.html |
Codecov Report
@@ Coverage Diff @@
## main #170 +/- ##
==========================================
+ Coverage 92.12% 92.13% +0.01%
==========================================
Files 90 90
Lines 16689 16689
==========================================
+ Hits 15374 15376 +2
+ Misses 1315 1313 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
reuterbal
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small fix the the member inlining utility and accompanying test.
The problem was the wrong use of symbol substitution, which we now face to rescope and rebuild when replicating the body of the child routine to the parent. This would otherwise in-place update associate statements, as they are type definitions, which creates issues for replicated calls, as the same object is used for separate substitutions.
Many thanks to @rolfhm for finding, flagging and triaging the problem and providing the accompanying test case.