Fix deep-cloning of subroutiens and modules (fix #174) #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/175/index.html |
mlange05
force-pushed
the
naml-fix-subroutine-deep-clone
branch
from
842b823 to
31e5e43
Compare
reuterbal
approved these changes
Oct 17, 2023
There was a problem hiding this comment.
Thanks for fixing this and providing tests for it! That was a subtle oversight, many thanks to @JoeffreyLegaux for flagging this.
|
Hi @mlange05, I just tested this branch on a large actual case, and everything seems to work fine. Thanks for the quick fix ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title implies, we were indeed not rebuilding nested
ScopedNodeobjects in the duplicationTransformerused for deep-copying (cloning) ofSubroutine/Moduleobjects. This PR fixes this and adds tests that include nestedScopedNodeobjects (Associatefor subroutine andTypeDeffor modules) in the duplicated IR.This should fix issue #174.
Many thanks to @JoeffreyLegaux for reporting and providing the reproducer for the subroutine case. I've slightly shortened the example code, but in essence it's the same problem. 😉 Please do confirm that this fixes things as you'd expect.