Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 'kernel_only=True' to RemoveCallsTransformation #185

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

MichaelSt98
Copy link
Collaborator

add kernel_only=True to RemoveCallsTransformation to avoid DrHook Calls being removed from driver routines.

This was part of the loki_transform.py ecphys() entry point, but not yet part of the convert() entry point. Tested with/for ecphys.

@MichaelSt98 MichaelSt98 requested a review from mlange05 November 7, 2023 12:09
Copy link

github-actions bot commented Nov 7, 2023

Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/185/index.html

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #185 (6f695b4) into main (af8ec9f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #185   +/-   ##
=======================================
  Coverage   92.14%   92.14%           
=======================================
  Files          90       90           
  Lines       16690    16690           
=======================================
  Hits        15379    15379           
  Misses       1311     1311           
Flag Coverage Δ
lint_rules 96.22% <ø> (ø)
loki 92.11% <ø> (ø)
transformations 91.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Collaborator

@reuterbal reuterbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uncontroversial, I think. Looks good to me, many thanks!

@reuterbal reuterbal added the ready for merge This PR has been approved and is ready to be merged label Nov 9, 2023
@reuterbal reuterbal merged commit 4b8c2a4 into main Nov 9, 2023
11 checks passed
@reuterbal reuterbal deleted the nams_remove_calls_kernel_only branch November 9, 2023 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for merge This PR has been approved and is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants