Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of empty files in frontends (fix #186) #187

Merged
merged 5 commits into from
Nov 13, 2023

Conversation

reuterbal
Copy link
Collaborator

No description provided.

@reuterbal reuterbal linked an issue Nov 9, 2023 that may be closed by this pull request
Copy link

github-actions bot commented Nov 9, 2023

Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/187/index.html

@reuterbal reuterbal force-pushed the 186-empty-file-regex-frontend branch from ccd6faf to c2ae243 Compare November 9, 2023 22:01
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #187 (443da5b) into main (df3f99a) will increase coverage by 0.02%.
Report is 25 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #187      +/-   ##
==========================================
+ Coverage   92.12%   92.14%   +0.02%     
==========================================
  Files          91       92       +1     
  Lines       16718    16761      +43     
==========================================
+ Hits        15402    15445      +43     
  Misses       1316     1316              
Flag Coverage Δ
lint_rules 96.22% <ø> (ø)
loki 92.11% <100.00%> (+0.02%) ⬆️
transformations 91.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
loki/backend/fgen.py 97.11% <100.00%> (ø)
loki/frontend/fparser.py 93.07% <100.00%> (ø)
loki/frontend/source.py 96.49% <100.00%> (+0.04%) ⬆️

... and 1 file with indirect coverage changes

Copy link
Collaborator

@mlange05 mlange05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uncontroversial, but needs a rebase now. GTG from my side.

Edit: No rebase needed now, I think. GTG.

@mlange05 mlange05 added the ready for merge This PR has been approved and is ready to be merged label Nov 13, 2023
@reuterbal reuterbal merged commit 9d27cab into main Nov 13, 2023
11 checks passed
@reuterbal reuterbal deleted the 186-empty-file-regex-frontend branch November 13, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for merge This PR has been approved and is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty source file fails in regex-frontend
2 participants