Small parsing fixes #190
Merged
Small parsing fixes #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awnawab
force-pushed
the
naan-parsing-fixes
branch
from
d82a1d7 to
f24a6a1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #190 +/- ##
=======================================
Coverage 92.16% 92.16%
=======================================
Files 93 93
Lines 16792 16793 +1
=======================================
+ Hits 15477 15478 +1
Misses 1315 1315
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
awnawab
force-pushed
the
naan-parsing-fixes
branch
from
f24a6a1 to
909dbd2
Compare
|
Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/190/index.html |
mlange05
approved these changes
Nov 20, 2023
There was a problem hiding this comment.
Looks sensible to me, so GTG from my side. Would like @reuterbal to have a quick look though too, as this stuff is complex. 👍
reuterbal
approved these changes
Nov 20, 2023
awnawab
force-pushed
the
naan-parsing-fixes
branch
from
d006e42 to
e19083c
Compare
|
Looks great now, merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two small parsing fixes:
With these changes, Loki can successfully parse the refactored
LAPINEA/LAPINEBkernels.