Nested derived type bug fix #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #192 +/- ##
=======================================
Coverage 92.32% 92.33%
=======================================
Files 95 95
Lines 17271 17272 +1
=======================================
+ Hits 15946 15948 +2
+ Misses 1325 1324 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rolfhm
force-pushed
the
sbrm-substitute-expressions-parent-change
branch
from
ba049e0 to
5231618
Compare
mlange05
force-pushed
the
sbrm-substitute-expressions-parent-change
branch
from
8759dc8 to
a0763b0
Compare
|
Hi @rolfhm I just found this, and have recently stumbled across a slightly better fix. I really like your test though, so I've just triggered a rebase, and will bring this in with the other fix on top, I think. Hope you don't mind? |
|
No problem. Glad it was of some use. |
mlange05
approved these changes
Jan 31, 2024
mlange05
added
the
ready to merge
reuterbal
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possibly a solution to issue #182