-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DataOffload: fix generation of offload pragmas #442
Conversation
b87b6ae
to
d0ce5e5
Compare
Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/442/index.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, makes sense and looks good to me. Approving now, but needs rebase once Pydantic version compatibility is fixed.
d0ce5e5
to
475e227
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! The fix looks good and also personally I'm of the opinion that white space behind commas is not a luxury that should lay beyond us :)
The question is whether we wouldn't want to make commas itself a delimiter for chunking in JoinableStringList
:
Line 57 in 72d35fb
_pattern_chunk_separator = re.compile(r'(\s|\)(?!%)|\n)') |
This pattern governs the split points in strings when long lines need to be wrapped.
I have pushed a rebase to include the pydantic compatibility change.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #442 +/- ##
==========================================
- Coverage 93.32% 93.32% -0.01%
==========================================
Files 212 212
Lines 40769 40769
==========================================
- Hits 38047 38046 -1
- Misses 2722 2723 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
475e227
to
1433bea
Compare
A small fix to how the global variable offload pragmas are generated which allows them to be split into multiple lines by
fgen
.