Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Linter warning #451

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Fix Linter warning #451

merged 1 commit into from
Nov 25, 2024

Conversation

reuterbal
Copy link
Collaborator

Apologies, a Linter check failure crept into main. This fixes the failing check.

@reuterbal reuterbal requested a review from mlange05 November 25, 2024 12:16
Copy link

Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/451/index.html

@reuterbal reuterbal mentioned this pull request Nov 25, 2024
Copy link
Collaborator

@mlange05 mlange05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, GTG.

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.24%. Comparing base (8dbdafc) to head (edbe8bf).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #451   +/-   ##
=======================================
  Coverage   93.24%   93.24%           
=======================================
  Files         220      220           
  Lines       41105    41105           
=======================================
  Hits        38327    38327           
  Misses       2778     2778           
Flag Coverage Δ
lint_rules 96.39% <ø> (ø)
loki 93.19% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@reuterbal reuterbal added the ready for merge This PR has been approved and is ready to be merged label Nov 25, 2024
@reuterbal reuterbal merged commit cd45a6c into main Nov 25, 2024
13 checks passed
@reuterbal reuterbal deleted the nabr-fix-linter-warning branch November 25, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for merge This PR has been approved and is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants