Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline: Avoid Import duplication from multiple callees #468

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

mlange05
Copy link
Collaborator

@mlange05 mlange05 commented Jan 8, 2025

The previous logic does not account for the same import modules being used by multiple callees, as it attempts to propagate imported symbols in one go. Instead, we now call a utility method for each callee, so that the previous redundancy mechanics avoid duplication across multiple callees, not just between caller and callee.

The previous logic does not account for the same import modules being
used by multiple callees, as it attempts to propagate imported symbols
in one go. Instead, we now call a utility method for each callee, so
that the previous redundancy mechanics avoid duplication across
multiple callees, not just between caller and callee.
@mlange05 mlange05 requested a review from reuterbal January 8, 2025 10:16
Copy link

github-actions bot commented Jan 8, 2025

Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/468/index.html

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.29%. Comparing base (ad1e2bc) to head (a4e6b90).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #468   +/-   ##
=======================================
  Coverage   93.29%   93.29%           
=======================================
  Files         221      221           
  Lines       41360    41382   +22     
=======================================
+ Hits        38587    38609   +22     
  Misses       2773     2773           
Flag Coverage Δ
lint_rules 96.39% <ø> (ø)
loki 93.25% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@reuterbal reuterbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and neatly tested. Many thanks!

@reuterbal reuterbal added the ready to merge This PR has been approved and is ready to be merged label Jan 8, 2025
@reuterbal reuterbal merged commit 1a09ea9 into main Jan 9, 2025
13 checks passed
@reuterbal reuterbal deleted the naml-inline-avoid-import-duplication branch January 9, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge This PR has been approved and is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants