Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependency on header files in loki_transform_target #471

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

reuterbal
Copy link
Collaborator

There was a typo in the variable name, possibly causing race conditions in parallel build when a header module is also generated.

@reuterbal reuterbal requested a review from mlange05 January 10, 2025 13:55
Copy link

Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/471/index.html

Copy link
Collaborator

@mlange05 mlange05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, looks good. GTG.

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.38%. Comparing base (4ed8534) to head (f64042c).
Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #471   +/-   ##
=======================================
  Coverage   93.38%   93.38%           
=======================================
  Files         226      226           
  Lines       41906    41906           
=======================================
  Hits        39136    39136           
  Misses       2770     2770           
Flag Coverage Δ
lint_rules 96.39% <ø> (ø)
loki 93.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reuterbal reuterbal added the ready for merge This PR has been approved and is ready to be merged label Jan 10, 2025
@reuterbal reuterbal merged commit 2cb393f into main Jan 10, 2025
13 checks passed
@reuterbal reuterbal deleted the nabr-fix-cmake-header-dependency branch January 10, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for merge This PR has been approved and is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants