Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shift $1 out prior to eval #100

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

zavorka
Copy link
Contributor

@zavorka zavorka commented Jul 14, 2021

Shift the first positional parameter out into a variable before running the eval command, so that it is not passed onto sourced scripts.

Fixes #89

Shift the first positional parameter out into a variable before running
the eval command, so that it is not passed onto sourced scripts.
@edc
Copy link
Owner

edc commented Jul 19, 2021

Sorry about the late response. Could you please add a quick test? Thanks!

Copy link
Owner

@edc edc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's much clearer if we just update L66 to replace bass with $1. WDYT?

@skycaptain
Copy link

@zavorka @edc anything we could to to push things forward?

@JDuchniewicz
Copy link

Is it possible to merge this any time forthcoming?

@yoeluk
Copy link

yoeluk commented Jun 16, 2022

this seems left behind but it is still very frustrating behaviour... I think that the change requested by @edc is essentially this command = 'shift; eval $1 && ({}; alias) >&{}'.format(. If this is correct, can we satisfy this @zavorka ?

mattbailey added a commit to mattbailey/bass that referenced this pull request Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

$1 is set in contrast to bash
5 participants