Skip to content

Commit

Permalink
fix: remove unnecesary annotations from the hpa sync wave (#119)
Browse files Browse the repository at this point in the history
The HPA sync-wave patch includes annotations to indicate argocd
in which order should the HPA resources be applied in relation
to the other resources. The `argocd.argoproj.io/hook: Sync`
and `argocd.argoproj.io/hook-delete-policy: HookSucceeded`
annotations are used for ephemeral resources (like jobs) and
should not be used for the HPA resources.

Co-authored-by: Moisés González <[email protected]>
  • Loading branch information
jfavellar90 and MoisesGSalas authored Jul 2, 2024
1 parent 485a190 commit 2b3debc
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions drydock/templates/drydock/k8s/patches/hpa-sync-wave.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,3 @@ metadata:
name: not-used
annotations:
argocd.argoproj.io/sync-wave: "{{ get_sync_waves_for_resource('horizontalpodautoscalers:all') }}"
argocd.argoproj.io/hook: Sync
argocd.argoproj.io/hook-delete-policy: HookSucceeded

0 comments on commit 2b3debc

Please sign in to comment.