feat: ORA staff grader endpoints upgraded #298
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: add non_editable for core notifications * test: add test case for non_editable in core notification * refactor: remove breakpoint from test cases
* fix: hide title for mobile users in program dashboard * fix: fix subscription trial remaining days logic
* chore: Adding pin to avoid test failures.
…nedx#32665) * feat: update user pref while sending notifications * feat: added flag and bulk create in task
* Revert "Revert "fix: mathjax resize on sindow resize (openedx#32606)"" This reverts commit 9dac65a. * fix: mathjax wrap overflow and flickering
* feat: added logic to handle core notifications
This adds the ability to get a list of detailed courses based on their keys provided in the newly added `keys` query param in the `GET /courses/v1/courses/` endpoint.
…nedx#32697)" (openedx#32719) This reverts commit 6b19eab.
To make edx-platform more consistent with other IDAs and to help deprecate more of paver, we are adding the ability to run `make migrate` in a local environment as a replacement for `paver update_db`. openedx-unsupported/devstack#1085
This gives us the abuliity to add some nice responsive web components to our docs. In particular girds and cards.
The guides map pretty closely to the concept docs in diataxis so rename them as such to align to the standard naming we're moving to.
There is still a lot of improvements that could be made to make the generated docs better organized. However, before this change we were generating the docs but they weren't in the doc tree so you couldn't actually browse to them. So we fix that first so that we can start getting feedback about how to organize them.
Some doc buildig deps were in development.in explicitly while others weren't. Update development.in to pull in doc.txt and then remove direct additions of the doc requirements from development.in
…urses-details-by-key feat: list courses details by keys
feanil/reorg guides
* feat: add new entitlements expiration endpoint
We are still seeing issues running devstack provisioning of LMS because it's missing pkg-config. We believe this might be the location we need to add the package to.
Ian2012
reviewed
Oct 19, 2023
Ian2012
reviewed
Oct 19, 2023
Ian2012
reviewed
Oct 19, 2023
Comment on lines
191
to
193
| except Exception as ex: | ||
| log.exception(ex) | ||
| return UnknownErrorResponse() |
There was a problem hiding this comment.
This is a too-broad exception, can you explain in which cases was this triggered?
| #init_data["assessments"] = TEST | ||
|
|
||
| response_data = FeedbackSerializer(init_data).data | ||
| log.info(response_data) |
Comment on lines
177
to
178
| # Get list of submissions for this ORA | ||
| init_data["assessments"] = get_assessments_grades(request, ora_location, submission_uuid, assessment_type) |
There was a problem hiding this comment.
I imagine this is the function that triggers the exception, can you cover only this statement in the try-except statement?
nandodev-net
changed the title
Comment on lines
172
to
174
| criterion_name = serializers.CharField() | ||
| score_earned = serializers.IntegerField() | ||
| score_type = serializers.CharField() |
There was a problem hiding this comment.
could any of these fields be optional or they're always present?
This was referenced Oct 25, 2023
cruise-control-service
force-pushed
the
master
branch
from
22ada3b to
0ebc69f
Compare
cruise-control-service
force-pushed
the
master
branch
from
0ebc69f to
0171b5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ORA staff grader endpoints upgrade
For this PR we have the following goals:
/api/ora_staff_grader/assessments/feedbackendpoint in order to list the assessments grades based on the type (received or given) for a specific submission./api/ora_staff_grader/initializeendpoint in order to add thefullnameandemailfields.Descriptions
/api/ora_staff_grader/assessments/feedback
This endpoint fetches assessment details for a given submission UUID, assessment_fillter [
given,received] and ORA_location, including scorer information and scoring details in order to fill the following Staff Grade MFE table:Click here! to see `/api/ora_staff_grader/assessments/feedback` output
{ "assessments": [ { "id_assessment": "17", "scorer_name": "Fernando Gonzalez", "scorer_username": "admin", "scorer_email": "[email protected]", "assesment_date": "17-10-2023", "assesment_scores": [ { "criterion_name": "Ideas", "score_earned": 5, "score_type": "Good" }, { "criterion_name": "Content", "score_earned": 5, "score_type": "Excellent" } ], "problem_step": "Staff", "feedback": "OVERALL WENO" }, ] }/api/ora_staff_grader/initialize
This is a pre-existing endpoint to which two extra fields are added [
fullname,email].Modifications were made in the following directories:
Click here! to see `/api/ora_staff_grader/initialize` output
This upgrade will consist of two PRs: one for ORA and the other for edx-platform. This is because the main serializer of the service resides in the platform. To test it, you'll need to fetch and set up the version of the platform with the serializer modification.