Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gameLeftPanel as gameRightPanel #974

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use gameLeftPanel as gameRightPanel #974

wants to merge 2 commits into from

Conversation

EgzoT
Copy link
Contributor

@EgzoT EgzoT commented Jun 16, 2018

It's provide to use gameLeftPanel (if it's ON) like gameRightPanel, by using function addToPanels().

When gameRightPanel is full:
leftpanel_as_rightpanel_16-06-2018

When in gameRightPanel one window is resized (now windows it's moved to gameLeftPanel, normal it's would be removed):
leftpanel_as_rightpanel_16-06-2018_2

New functions:
[modules.game_interface] addToPanels(<UIWidget>) - they set uiminiwindow in gameRightPanel or in gameLeftPanel (according on free place) priority gameRightPanel [function may set uiminiwindow to gameLeftPanel only when it's ON], additional they moved (if find free place in gameRightPanel or gameLeftPanel) window when we add other uiminiwindow or resize one from them when uiminiwindowcontainer is full (instead remove) to other Panel.

UIMiniWindowContainer:getEmptySpaceHeight() - return height of UIMiniWindowContainer without windows (uiminiwindow), who we may set to other windows.

New signals (signalcall):
UIMiniWindowContainer.onRemoveFromContainer [<UIWidget>] - return UIWidget who want to be removed (before deleted who provide to set operation to stopped deleted this UIWidget [change parent]) from UIMiniWindowContainer (by UIMiniWindowContainer:fitAll()).

@pasturryx
Copy link

I have extra right panel on my otclient how can i add that panel into this code?

@slavidodo
Copy link
Collaborator

This is a good start at which we can actually support multiple containers.
Any chance we could see this dynamically handled by the user using an "arrow" on the top corner of the last panel?

I'm looking to merging this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants