Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: quick fix for primary enrolment data #22

Merged
merged 16 commits into from
Jul 17, 2024

Conversation

rnr
Copy link
Collaborator

@rnr rnr commented Jul 17, 2024

This PR is quick fix for openedx#491
Changed type of auditAccessExpires to String.

volodymyr-chekyrta and others added 14 commits June 21, 2024 14:45
* feat: firebase cloud messaging

* fix: address feedback

* fix: address feedback
)

* chore: fix double notification routing and segment callback

* refactor: address review feedback

* refactor: address review feedback
* feat: fullstory SDK integration and analytics implementation

* chore: adding new screen events

* chore: update user-defined flag to build settings based on config

---------

Co-authored-by: Anton Yarmolenko <[email protected]>
* fix: crash with CoreData

* chore: moved to coreData to background queue

* chore: moved core data work to background

* chore: review's changes
* chore: theme enhancement

* chore: theme enhancements

* chore: theme improvements

* chore: address design team feedback

* chore: adding new color for coursecardbackground

* fix: using correct colors for openedX

* fix: using irreversibleAlert in registration to highlight errors

* fix: comment added pop-up message text is not visible in dark mode

* refactor: fix typo
@rnr rnr requested review from forgotvas and saeedbashir July 17, 2024 12:23
@saeedbashir
Copy link

Please update the PR title to fix: Quick Fix for primary enrolment data so on merging it will not create any issue for commit messages

@rnr rnr changed the title Quick Fix for primary enrolment data fix: quick fix for primary enrolment data Jul 17, 2024
Copy link

@saeedbashir saeedbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@forgotvas forgotvas merged commit d89d587 into 2U/develop Jul 17, 2024
2 of 3 checks passed
@forgotvas forgotvas deleted the fix/PrimaryEnrollment_data branch July 17, 2024 20:21
rnr pushed a commit that referenced this pull request Sep 6, 2024
fix: quick fix for primary enrolment data
rnr added a commit that referenced this pull request Sep 30, 2024
* Merge pull request #22 from edx/fix/PrimaryEnrollment_data

fix: quick fix for primary enrolment data

* chore: deleted unused parameter for init

---------

Co-authored-by: Vadim Kuznetsov <[email protected]>
Co-authored-by: Anton Yarmolenko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants