forked from openedx/openedx-app-ios
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: quick fix for primary enrolment data #22
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: firebase cloud messaging * fix: address feedback * fix: address feedback
* feat: fullstory SDK integration and analytics implementation * chore: adding new screen events * chore: update user-defined flag to build settings based on config --------- Co-authored-by: Anton Yarmolenko <[email protected]>
Settings button for dashboard type 'list'
* fix: crash with CoreData * chore: moved to coreData to background queue * chore: moved core data work to background * chore: review's changes
* chore: theme enhancement * chore: theme enhancements * chore: theme improvements * chore: address design team feedback * chore: adding new color for coursecardbackground * fix: using correct colors for openedX * fix: using irreversibleAlert in registration to highlight errors * fix: comment added pop-up message text is not visible in dark mode * refactor: fix typo
Please update the PR title to |
rnr
changed the title
Quick Fix for primary enrolment data
fix: quick fix for primary enrolment data
Jul 17, 2024
saeedbashir
approved these changes
Jul 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
forgotvas
approved these changes
Jul 17, 2024
rnr
pushed a commit
that referenced
this pull request
Sep 6, 2024
fix: quick fix for primary enrolment data
rnr
added a commit
that referenced
this pull request
Sep 30, 2024
* Merge pull request #22 from edx/fix/PrimaryEnrollment_data fix: quick fix for primary enrolment data * chore: deleted unused parameter for init --------- Co-authored-by: Vadim Kuznetsov <[email protected]> Co-authored-by: Anton Yarmolenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is quick fix for openedx#491
Changed type of auditAccessExpires to String.