Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: hide progress points from assignment status #100

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

saeedbashir
Copy link

Description
LEARNER-10266

We'd hide the progress points when the descendants of a subsection aren't available under this PR: #99. It turns out, in the case of the verified track, the server is returning all the descendants, and the instructor still has an option to hide the progress points.

At the moment, the server is not returning that information in the blocks API, so for the time being, to address the CR, we are hiding progress points altogether. We will bring them back when the server starts sending the progress hide/show boolean in the blocks API.

Copy link

@shafqat-muneer shafqat-muneer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@saeedbashir saeedbashir requested a review from forgotvas December 2, 2024 06:13
@saeedbashir saeedbashir merged commit dd6344c into 2U/develop Dec 2, 2024
2 checks passed
@saeedbashir saeedbashir deleted the saeed/LEARNER-10266 branch December 2, 2024 06:25
@rnr
Copy link
Collaborator

rnr commented Dec 3, 2024

@saeedbashir Is there some ticket or request for backend to add this hide/show boolean in the blocks API? Could you please mention it here? Thank you

@saeedbashir
Copy link
Author

@saeedbashir Is there some ticket or request for backend to add this hide/show boolean in the blocks API? Could you please mention it here? Thank you

Yes, LEARNER-10329 is the ticket for backend to add visibility flag in the blocks API.

rnr added a commit that referenced this pull request Jan 9, 2025
* chore: add video and discussion analytics (#93)

* fix: fixes after merge, deleted IAP parts

* chore: changed dependency version, deleted unused analytics part

* chore: regenerate mocks

* chore: In app ratings modal and profile picture picture sheet UI improvements (#94)

* chore: show subtitles for videos in full-screen mode (#97)

* fix: after merge

* fix: iOS 18 Toggle tap gesture (#98)

* fix: added priority for toggle tap gesture

* fix: fixed tap and drag actions for Toggle

---------

Co-authored-by: Anton Yarmolenko <[email protected]>

* fix: gesture for ios 18.2

* chore: quick fix with performance for subtitles view

* chore: sign-in and register screens social sign in improvements (#95)

* chore: fix after merge

* fix: fix microsoft login issue on iOS after config branch merges (#96)

* refactor: change the microsoft key name in the script (#101)

* chore: fix access modifier

* chore: re-generate nocks

* chore: hide grades when sub section dependents not available (#99)

* chore: fix after merge

* chore: hide progress points from assignment status (#100)

* chore: fix test

---------

Co-authored-by: Saeed Bashir <[email protected]>
Co-authored-by: Anton Yarmolenko <[email protected]>
Co-authored-by: Shafqat Muneer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants