Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update upgrade button and resume button style #30

Merged
merged 2 commits into from
Jul 19, 2024

Conversation

saeedbashir
Copy link

@saeedbashir saeedbashir commented Jul 19, 2024

Changing the color of the upgrade button to orange (button action color) and resume button style to secondary brand button as requested by Moiz.

https://2u-internal.atlassian.net/browse/LEARNER-10117

light mode Dark Mode
LightMode LightMode

@saeedbashir saeedbashir changed the title chore: update upgrade button and progress bar color chore: update upgrade button and resume button style Jul 19, 2024
@rnr
Copy link
Collaborator

rnr commented Jul 19, 2024

@saeedbashir tests look broken. please look on this. thank you

Copy link

@shafqat-muneer shafqat-muneer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@saeedbashir saeedbashir merged commit c078524 into 2U/develop Jul 19, 2024
3 checks passed
@saeedbashir saeedbashir deleted the saeed/update_colors branch July 19, 2024 13:46
@marcotuts
Copy link

I don't think this is a change we expect to merge in upstream, the resume / start course buttons should remain primary and the upgrade button placement is specific to the edX build.

@saeedbashir
Copy link
Author

I don't think this is a change we expect to merge in upstream, the resume / start course buttons should remain primary

@marcotuts I've made the resume button configurable in this PR #92. It will be primary for the openedX and edX(or any other provider) can configure it as per need.

and the upgrade button placement is specific to the edX build

At the moment, yes the placement is edX specific, we have the plan to push the payment-related generic code (UI, config, parsing, etc) upstream, so for that do you or Sam have any mockup available with upgrade button on the course home screen?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants