-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable configurable header #560
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #560 +/- ##
==========================================
+ Coverage 72.32% 73.15% +0.82%
==========================================
Files 52 52
Lines 813 838 +25
Branches 158 171 +13
==========================================
+ Hits 588 613 +25
Misses 215 215
Partials 10 10 ☔ View full report in Codecov by Sentry. |
0645152
to
554e6df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add/render a configurable Header
in example/index.jsx as default components are added for local testing
554e6df
to
61a6c77
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
61a6c77
to
ec6be49
Compare
This PR makes the header configurable by accepting the custom menu in props. This replicates this feature from openedx/frontend-component-header. (Reference PR)
Details:
This PR adds the following functionality:
Screenshots of using custom headers for replicating different MFE headers.
Note: Screenshots are with local setup.