Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable optional POST redirects #408

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

andreasonny83
Copy link

@andreasonny83 andreasonny83 commented Nov 6, 2024

Allow users to optionally enable redirects to POST requests.

Comparing_einaregilsson_master___andreasonny83_enable-post_·_einaregilsson_Redirector

@Gitoffthelawn
Copy link
Collaborator

This looks fantastic! Thank you! How well have you tested it so far?

@andreasonny83
Copy link
Author

This looks fantastic! Thank you! How well have you tested it so far?

I'm actually using it at work for mocking the backend API when running the project locally. Since I need to mock both GET and POST requests, I can say this is perfectly working as expected. By default, the POST requests don't get mocked, but as soon as I enable the POST checkbox, everything start working as expected

@Gitoffthelawn
Copy link
Collaborator

Gitoffthelawn commented Nov 7, 2024

This looks fantastic! Thank you! How well have you tested it so far?

I'm actually using it at work for mocking the backend API when running the project locally. Since I need to mock both GET and POST requests, I can say this is perfectly working as expected. By default, the POST requests don't get mocked, but as soon as I enable the POST checkbox, everything start working as expected

Great! Which browser(s) and OS(es) have you tested it on? If you will, please include version numbers. Thanks.

@andreasonny83
Copy link
Author

Tested on MacOS against Microsoft Edge v130.0.2849.46 and Chrome v130.0.6723.117

@Gitoffthelawn
Copy link
Collaborator

Thanks. Do you have any other browsers and/or OSes (perhaps via VM) on which you can test? In addition to your existing tests, I'm thinking Firefox, Windows, and Linux tests are needed to cover a good chunk of our user base.

Copy link
Collaborator

@Gitoffthelawn Gitoffthelawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This looks good and can be merged once #408 is merged and released.

Edit: GitHub UI makes it a bit confusing.. the above code review comment was for a change to the README in relation to POST functionality.

@andreasonny83
Copy link
Author

Sorry @Gitoffthelawn but I did not get your last comment. This is the PR #408. Are you asking me to take out the Readme update from this PR? That was just added to provide customer's documentation about the added functionality

@Gitoffthelawn
Copy link
Collaborator

Sorry @Gitoffthelawn but I did not get your last comment. This is the PR #408. Are you asking me to take out the Readme update from this PR? That was just added to provide customer's documentation about the added functionality

No problem. The GitHub UI can be confusing to others for this, and I was trying to clarify (and I clearly failed!). My comment "looks good..." was created when I performed the "code review" for your edit the readme. I was saying it looks good and can be merged once the corresponding code is merged is and release. But the GitHub UI doesn't make that clear, so I tried to clear that up, and I obviously failed in a spectacular fashion! 🤣

But, now that you mention it, maybe my comedic mishap resulted in some good. It may actually be better to separate the PR for the README. Why? Because we don't want to change the README until the code is actually released, not just when it's merged. I may be mistaken (please tell me if I am), but I think if I merge the code now, the updated README will be available now (before the code is released), which will confuse people.

This reverts commit 7c39f6f.
@andreasonny83
Copy link
Author

Thanks for the clarification @Gitoffthelawn .
I have now reverted the Readme update commit as suggested

@andreasonny83
Copy link
Author

Any update on this one @Gitoffthelawn? Is this PR ready for merge now?

@Gitoffthelawn
Copy link
Collaborator

Any update on this one @Gitoffthelawn? Is this PR ready for merge now?

It just needs testing on Linux & Windows, and on Firefox. Ideally, it will work perfectly.

@andreasonny83
Copy link
Author

Any update on this one @Gitoffthelawn? Is this PR ready for merge now?

It just needs testing on Linux & Windows, and on Firefox. Ideally, it will work perfectly.

Will you cover that testing? I cannot test that at my end unfortunately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants