Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Korean Translation file (for fixing #51) #127

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

moseskim
Copy link

@moseskim moseskim commented Sep 21, 2016

This PR offers a Korean translation of the gitinspector application (as referenced in #51).

  • added messages_ko.po
  • modified README.md for changing member or Korean translation

Any feedback would be appreciated.

Regards.

Moses-Kim-NBT and others added 4 commits September 21, 2016 16:42
Added Korean Translation file
corrected type
Member responsible for Korean translation has changed from 'Jiwon Kim' to 'Moses Kim'
@adam-waldenberg
Copy link
Member

Hi. Looks good.

Were the following ones skipped on purpose?:

+msgid "% in comments"
+msgstr "% in comments"

+msgid "% of changes"
+msgstr "% of changes"

+msgid "Commits"
+msgstr "Commits"

@moseskim
Copy link
Author

You're right.

Those three terms have been used as the original ones on purpose, because those original messages are more easier and clearer to understand, I thought.

@adam-waldenberg
Copy link
Member

adam-waldenberg commented Sep 23, 2016

@moseskim Very well. As far as I am concerned you are the boss of this file - so you decide. I'll include the translation in the next 0.4.5 release.

@moseskim
Copy link
Author

@adam-waldenberg
good. I decide that I will use those three terms as not translated .
Thanks you for your advice and review comments.

Hope that I can enjoy the Korean translation in later release 0.4.5.

Regards

@moseskim moseskim closed this Sep 23, 2016
@moseskim moseskim reopened this Sep 23, 2016
@adam-waldenberg
Copy link
Member

Moved to 0.5.0.

@adam-waldenberg adam-waldenberg modified the milestones: 0.4.5, 0.5.0 Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants