Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for us-isof and eu-isoe regions #8112

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jdwtf
Copy link

@jdwtf jdwtf commented Jan 3, 2025

Description

Adding support for new isolated AWS regions to include necessary changes for testing and fixing linter errors/complaints. A prototype binary was generated with these changes and we are able to successfully test functionality in region.

Key Changes For Build:

  • pkg/apis/eksctl.io/v1alpha5/partitions.go: added
    • partitions strings
    • partitions objects with region-appropriate
      • service mappings
      • domain prefixes
    • added partitions to ISO part of GetEndpointServiceDomainPrefix
  • pkg/apis/eksctl.io/v1alpha5/types.go: added
    • in-region resource account IDs
    • region strings
    • SupportedRegions strings

Key Changes For Testing:

  • pkg/actions/nodegroup/testdata all *.json files updated ServicePrincipalPartitionMap
  • pkg/cfn/builder/karpenter_test.go updated expectedTemplate* template strings
  • pkg/cfn/builder/testdata/nodegroup_access_entry all *.json files ServicePrincipalPartitionMap
  • pkg/cfn/builder/testdata/ added service_details_isob.json, service_details_isoe.json, service_details_isof.json
  • pkg/cfn/builder/vpc_endpoint_test.go to add tests for isob, isoe and isof

Documentation:

  • added new regions' information to
    • userdocs/theme/home.html
    • userdocs/src/getting-started.md

Linter Warnings/Errors:

  • integration/tests/crud/creategetdelete_test.go: error and return value check for Sscanf
  • added static string formatting to
    • cmd/eksctl/logger.go
    • pkg/actions/accessentry/task.go
    • pkg/actions/addon/tasks.go
    • pkg/actions/anywhere/anywhere.go
    • pkg/actions/podidentityassociation/tasks.go
    • pkg/cfn/template/matchers/matchers.go
    • pkg/eks/api_test.go
    • pkg/ssh/client/ssh.go
  • unnecessary nil checks for 0 length slice
    • pkg/apis/eksctl.io/v1alpha5/addon.go
    • pkg/apis/eksctl.io/v1alpha5/addon.go

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello jdwtf 👋 Thank you for opening a Pull Request in eksctl project. The team will review the Pull Request and aim to respond within 1-10 business days. Meanwhile, please read about the Contribution and Code of Conduct guidelines here. You can find out more information about eksctl on our website

@jdwtf jdwtf marked this pull request as ready for review January 3, 2025 22:08
@jdwtf
Copy link
Author

jdwtf commented Jan 3, 2025

addresses #8095

@jdwtf jdwtf marked this pull request as draft January 3, 2025 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant