Update to latest ingest that attempts to flush out buffer before full…

…y disposing (#440) This also updates our serology sink to implement `IDisposable` so it waits to flush as well. See also #411
elastic · Sep 18, 2024 · 5134fe2 · 5134fe2
1 parent 88365f4
commit 5134fe2
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/...lastic.Ingest.Elasticsearch.CommonSchema/Elastic.Ingest.Elasticsearch.CommonSchema.csproj b/...lastic.Ingest.Elasticsearch.CommonSchema/Elastic.Ingest.Elasticsearch.CommonSchema.csproj
@@ -10,7 +10,7 @@
   </ItemGroup>
 
   <ItemGroup>
-    <PackageReference Include="Elastic.Ingest.Elasticsearch" Version="0.7.0" />
+    <PackageReference Include="Elastic.Ingest.Elasticsearch" Version="0.7.1" />
   </ItemGroup>
 
 </Project>
diff --git a/src/Elastic.Serilog.Sinks/ElasticsearchSink.cs b/src/Elastic.Serilog.Sinks/ElasticsearchSink.cs
@@ -93,7 +93,7 @@ public ElasticsearchSink(ElasticsearchSinkOptions options) : base(options) {}
 	}
 
 	/// <inheritdoc cref="ElasticsearchSink"/>>
-	public class ElasticsearchSink<TEcsDocument> : ILogEventSink
+	public class ElasticsearchSink<TEcsDocument> : ILogEventSink, IDisposable
 		where TEcsDocument : EcsDocument, new()
 	{
 		private readonly EcsTextFormatterConfiguration<TEcsDocument> _formatterConfiguration;
@@ -121,6 +121,8 @@ public void Emit(LogEvent logEvent)
 			_channel.TryWrite(ecsDoc);
 		}
 
+		/// <summary> Disposes and flushed <see cref="EcsDataStreamChannel{TEcsDocument}"/> </summary>
+		public void Dispose() => _channel.Dispose();
 	}
 
 	internal class SelfLogCallbackListener<TEcsDocument> : IChannelCallbacks<TEcsDocument, BulkResponse> where TEcsDocument : EcsDocument, new()

diff --git a/tests-integration/Elasticsearch.IntegrationDefaults/Elasticsearch.IntegrationDefaults.csproj b/tests-integration/Elasticsearch.IntegrationDefaults/Elasticsearch.IntegrationDefaults.csproj
@@ -11,7 +11,7 @@
   <ItemGroup>
     <PackageReference Include="Elastic.Clients.Elasticsearch" Version="8.12.1" />
     <PackageReference Include="Elastic.Elasticsearch.Xunit" Version="0.4.3" />
-    <PackageReference Include="Elastic.Ingest.Elasticsearch" Version="0.7.0" />
+    <PackageReference Include="Elastic.Ingest.Elasticsearch" Version="0.7.1" />
 
   </ItemGroup>